Merge branch 'main' into pytree_qml_counts_issue_arjun_bhamra

PennyLaneAI · Oct 30, 2024 · 3064287 · 3064287
2 parents 440aa84 + 018ce9c
commit 3064287
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/check-pl-compat.yaml b/.github/workflows/check-pl-compat.yaml
@@ -156,7 +156,7 @@ jobs:
       uses: actions/checkout@v4
       with:
         repository: PennyLaneAI/pennylane-lightning
-        ref: v0.38.0_rc
+        ref: v0.39.0_rc
         path: lightning_build
         fetch-depth: 0
 

diff --git a/mlir/lib/Gradient/Transforms/GradMethods/PS_QuantumGradient.cpp b/mlir/lib/Gradient/Transforms/GradMethods/PS_QuantumGradient.cpp
@@ -56,7 +56,7 @@ static std::vector<Value> computePartialDerivative(PatternRewriter &rewriter, Lo
                                                    Value selectorBuffer, func::FuncOp shiftedFn,
                                                    std::vector<Value> callArgs)
 {
-    constexpr double shift = PI / 2;
+    constexpr double shift = llvm::numbers::pi / 2;
     ShapedType shiftVectorType = RankedTensorType::get({numShifts}, rewriter.getF64Type());
     Value selectorVector = rewriter.create<bufferization::ToTensorOp>(loc, selectorBuffer);
 

diff --git a/mlir/lib/Gradient/Transforms/GradMethods/ParameterShift.hpp b/mlir/lib/Gradient/Transforms/GradMethods/ParameterShift.hpp
@@ -21,8 +21,6 @@
 
 #include "Gradient/IR/GradientOps.h"
 
-constexpr double PI = 3.14159265358979323846;
-
 using namespace mlir;
 
 namespace catalyst {