[Frontend] Only read from disk if necessary #1315
Draft
+44
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The QIR and MLIR fields in the QJIT object are purely used for either debugging or cosmetic features. As such, their implementation should really be optional and not affect compile time.
Description of the Change: This commit introduces the change that the fields QIR and MLIR are computed lazily to avoid reading their contents from disk. Instead of unconditionally reading them from disk, just read them from disk if the user really wants them.
Benefits: Not yet benchmarked, but ideally it should reduce compilation time.
Possible Drawbacks: The size of LLVM-IR is not measured through instrumentation in the current state of this PR.
Related GitHub Issues: