-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hermitian Support for Finite-Shot Measurement Statistics #451
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 99.95% 97.95% -2.01%
==========================================
Files 20 71 +51
Lines 4439 10505 +6066
Branches 0 886 +886
==========================================
+ Hits 4437 10290 +5853
- Misses 2 170 +168
- Partials 0 45 +45 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @multiphaseCFD 🥳
I think we also need to make sure that our wheels are built correctly. I would imagine that we need to add the lapack library to our binary distribution, unless you link it into lightning statically? Or does lightning look for it at runtime?
We also need to ensure the change works on MacOS (installing the liblapack-dev
equivalent etc), running the wheel build action for mac from this branch would be a good test for it.
@@ -38,7 +38,7 @@ jobs: | |||
|
|||
- name: Install deps | |||
run: | | |||
sudo apt-get install -y cmake ninja-build ccache libomp-dev libasan6 | |||
sudo apt-get install -y cmake ninja-build ccache libomp-dev liblapack-dev libasan6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're adding the package here it probably needs to be added to all our other actions as well (where appropriate).
Our install docs also need to reflect this new dependency:
catalyst/doc/dev/installation.rst
Line 66 in 300ff89
Building from source |
runtime/Makefile
Outdated
@@ -14,7 +14,8 @@ ENABLE_LIGHTNING?=ON | |||
ENABLE_LIGHTNING_KOKKOS?=OFF | |||
ENABLE_OPENQASM?=OFF | |||
ENABLE_ASAN?=OFF | |||
LIGHTNING_GIT_TAG_VALUE?="v0.34.0" | |||
ENABLE_LAPACK?=ON | |||
LIGHTNING_GIT_TAG_VALUE?="master" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we target the minimum commit on the master branch that introduced support? Having a fixed hash will allow us to go back through Catalyst's git history and still build it successfully.
runtime/Makefile
Outdated
@@ -14,7 +14,8 @@ ENABLE_LIGHTNING?=ON | |||
ENABLE_LIGHTNING_KOKKOS?=OFF | |||
ENABLE_OPENQASM?=OFF | |||
ENABLE_ASAN?=OFF | |||
LIGHTNING_GIT_TAG_VALUE?="v0.34.0" | |||
ENABLE_LAPACK?=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option is added but unused?
Thanks @dime10 ! Per packaging/wheels building, we should add |
The one problem I see with this is that for deployed packages (like a Catalyst wheel), the correct RPATH (on the user's system) is not known at build time. |
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Shortcut Stories:
[sc-53754]