Add missing Lidar parameter #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlarkin
approved these changes
Jun 4, 2024
dyackzan
reviewed
Jun 4, 2024
dyackzan
requested changes
Jun 4, 2024
There was a problem hiding this comment.
I think the right fix is to make a change in the ros2_mujoco library that holds defaults for this parameter or doesn't require it unless a lidar is present in the model. I feel like this will cause confusion down the road if we require configs to set lidar params when they don't use lidars
|
Good points, thanks @dyackzan. I did not think about the scenario where lidar isn't being used. I'm also in favor of making this default to something to handle both lidar/no lidar use cases. |
|
@adlarkin @dyackzan Made a PR for making the |
|
Closing since https://github.com/PickNikRobotics/ros2_mujoco/pull/28 will take care of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the LIDAR PR that went into the
ros2_mujocorepo, alidar_publish_rateros2_controlparameter is now required. This PR adds that PR to the Kinova URDF.