Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landsat scene #34

Merged
merged 12 commits into from
Jun 7, 2024
Merged

Landsat scene #34

merged 12 commits into from
Jun 7, 2024

Conversation

pac48
Copy link
Contributor

@pac48 pac48 commented Jun 5, 2024

No description provided.

pac48 added 6 commits June 4, 2024 10:52
Signed-off-by: Paul Gesel <[email protected]>
Signed-off-by: Paul Gesel <[email protected]>
Signed-off-by: Paul Gesel <[email protected]>
Signed-off-by: Paul Gesel <[email protected]>
Signed-off-by: Paul Gesel <[email protected]>
@pac48 pac48 requested a review from dyackzan June 5, 2024 21:17
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to make an entirely new objective for the landsat and preserve the original. Maybe name one "Compliant Grasp Landsat" and the other "Compliant Grasp Mock Satellite"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make another scene file like "landsat_scene.xml" and preserve this one. We'll swap them out using a xacro param in the .xacro file when we want to switch between scenes

@pac48 pac48 requested a review from dyackzan June 7, 2024 16:14
@pac48 pac48 marked this pull request as ready for review June 7, 2024 16:14
@pac48 pac48 merged commit e7a2791 into main Jun 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants