Fix #2, modernize and support plain import #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@altendky , do you feel like taking a look at this? |
altendky
reviewed
Nov 28, 2023
pygrep/__init__.py
Outdated
| class IdentVisitor(ast.NodeVisitor): | ||
| def __init__(self, path, ident, callback): | ||
| class IdentVisitor: | ||
| def __init__(self, ident: str): | ||
| super(IdentVisitor, self).__init__() |
There was a problem hiding this comment.
In so much as you want to keep this around, this fits into a 2->3 conversion pattern. I think technically everything should super init, but we usually don't bother...
Suggested change
| super(IdentVisitor, self).__init__() | |
| super().__init__() |
| yield (path, *t) | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
If you want to make pygrep 'more runnable', you may want a pygrep/__main__.py. That's what would be run for python -m pygrep, for example. It could consist of nothing more than import pygrep; pygrep.main().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a bit of stuff from back then changed.
Also add support for regular
import foo.bar, and, well, tests.