Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Vendure Variant Bulk Update plugin to vendure 2.0 #227

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Upgraded Vendure Variant Bulk Update plugin to vendure 2.0 #227

merged 2 commits into from
Jul 26, 2023

Conversation

dalyathan
Copy link
Member

Description

The changes should make Vendure Variant Bulk Upload Plugin compatible with vendure 2.0. Should close #226

Breaking changes

This PR won't include any breaking changes.

Checklist

Please make sure you've done the following checks:

  • I have set a clear title
  • My PR is small and contains only a single feature. (Split into multiple PR's if needed)
  • I have added or updated test cases for important functionality
  • I have updated the README if needed
  • I have reviewed my own PR
  • I have fixed all typo's and have removed unused or commented code

@dalyathan dalyathan linked an issue Jul 25, 2023 that may be closed by this pull request
Upgrade Vendure Variant Bulk Update Plugin to Vendure 2.0 #226
Closed
@dalyathan dalyathan changed the title Upgraded Vendure Variant Bulk Upload plugin to vendure 2.0 Upgraded Vendure Variant Bulk Update plugin to vendure 2.0 Jul 25, 2023
martijnvdbrug
martijnvdbrug approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@martijnvdbrug martijnvdbrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@martijnvdbrug martijnvdbrug merged commit b8b4310 into v2 Jul 26, 2023
6 of 10 checks passed
@martijnvdbrug martijnvdbrug deleted the v2-bulk-update-plugin branch July 26, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvdbrug martijnvdbrug martijnvdbrug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Vendure Variant Bulk Update Plugin to Vendure 2.0
2 participants
@dalyathan @martijnvdbrug