Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved osd patch basis compatibility #1321

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Improved osd patch basis compatibility #1321

merged 2 commits into from
Sep 14, 2023

Commits on Sep 13, 2023

  1. Reorganized osd/patchBasis and osd/patchBasisTypes 

    Folded osd/patchBasisCommon.h and osd/patchBasisCommonEval.h into the
single header file osd/patchBasis.h and renamed osd/PatchBasisCommonTypes.h
to osd/patchBasisTypes.h

Moved these into the OpenSubdiv::Osd namespace when compiled for C++ and
added a brief comment describing the intended use cases for this code.
    @davidgyu
    davidgyu committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    fa5b57c View commit details
    Browse the repository at this point in the history

  2. Installed osd/patchBasis.h and osd/patchBasisTypes.h 

    Providing these as public headers in opensubdiv/osd allows client code
to implement evaluation kernels in their own TBB, CUDA, OMP, GCD, etc.
code without needing an implementation within the osd codebase.

Tested with C++, CUDA, and oneTBB client kernels.
    @davidgyu
    davidgyu committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    be4c718 View commit details
    Browse the repository at this point in the history