feat: add has_potion_effect and potion_effect_level (closes #66)
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGabyTM
changed the title
potion_has and potion_level (close #66)potion_has and potion_level (closes #66)
src/main/java/com/extendedclip/papi/expansion/player/PlayerExpansion.java
Outdated
Show resolved
Hide resolved
As @BlitzOffline pointed out, `has_potion_effect` makes more sense than `potion_has`
Because these placeholders requires an argument they need to be outside the switch block
iGabyTM
changed the title
potion_has and potion_level (closes #66)has_potion_effect and potion_level (closes #66)
Last edit, I promise 😬
iGabyTM
changed the title
has_potion_effect and potion_level (closes #66)has_potion_effect and potion_effect_level (closes #66)
BlitzOffline
approved these changes
Jun 21, 2023
|
Just saw this pop up in the discord, and was just curious about adding I noticed extra code was also put in for the new one, instead of them running the same thing code. |
|
Because I did not see it welp |
Closed
darbyjack
approved these changes
Jun 24, 2024
|
I've included this ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has to be merged after #83