Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter hic_samtools_ext_args #165

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Added parameter hic_samtools_ext_args #165

merged 1 commit into from
Oct 25, 2024

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Oct 25, 2024

PR checklist

  • Added parameter hic_samtools_ext_args
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@GallVp GallVp linked an issue Oct 25, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 25, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c1f83cc

+| ✅ 164 tests passed       |+
#| ❔  32 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • schema_lint - Schema $id should be https://raw.githubusercontent.com/plant-food-research-open/assemblyqc/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/plant-food-research-open/assemblyqc/main/nextflow_schema.json

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-assemblyqc_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-assemblyqc_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-assemblyqc_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config variable ignored: validation.help.beforeText
  • nextflow_config - Config variable ignored: validation.help.afterText
  • nextflow_config - Config variable ignored: validation.summary.beforeText
  • nextflow_config - Config variable ignored: validation.summary.afterText
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File does not exist: assets/nf-core-assemblyqc_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-assemblyqc_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-assemblyqc_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/assemblyqc/assemblyqc/.github/workflows/awstest.yml
  • template_strings - template_strings
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-25 03:29:56

@GallVp GallVp merged commit 26025a4 into dev Oct 25, 2024
11 checks passed
@GallVp GallVp deleted the hic/filter branch October 25, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PCR duplicates are not removed in the HiC workflow
1 participant