Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dev compatibility for monitoring #2692

Conversation

andriacap
Copy link
Contributor

Ajout de développements pour que les nouvelles fonctionnalités de Monitorings fonctionnent.

Principalement ce sont des développements qui concernent les composants de formulaire.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9198f63) 78.44% compared to head (261d13d) 68.57%.

❗ Current head 261d13d differs from pull request most recent head 29a8c91. Consider uploading reports for the commit 29a8c91 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2692      +/-   ##
===========================================
- Coverage    78.44%   68.57%   -9.88%     
===========================================
  Files           88       86       -2     
  Lines         7182     7436     +254     
===========================================
- Hits          5634     5099     -535     
- Misses        1548     2337     +789     
Flag Coverage Δ
pytest 68.57% <100.00%> (-9.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andriacap andriacap force-pushed the feat/dev-compatibility-for-monitoring branch from ec41144 to c413ef3 Compare September 12, 2023 10:20
andriacap added a commit to naturalsolutions/gn_module_monitoring that referenced this pull request Oct 6, 2023
Move migration alembic for "add_observers_txt_column_t_base_vist"
to GeoNature

See PR: PnX-SI/GeoNature#2692

Reviewed-by: andriacap
amandine-sahl pushed a commit to PnX-SI/gn_module_monitoring that referenced this pull request Oct 10, 2023
Move migration alembic for "add_observers_txt_column_t_base_vist"
to GeoNature

See PR: PnX-SI/GeoNature#2692

Reviewed-by: andriacap
amandine-sahl pushed a commit to naturalsolutions/gn_module_monitoring that referenced this pull request Oct 10, 2023
Move migration alembic for "add_observers_txt_column_t_base_vist"
to GeoNature

See PR: PnX-SI/GeoNature#2692

Reviewed-by: andriacap
@andriacap andriacap force-pushed the feat/dev-compatibility-for-monitoring branch from cc14b67 to c614d51 Compare November 3, 2023 17:34
@camillemonchicourt camillemonchicourt added this to the 2.14 milestone Nov 13, 2023
@andriacap andriacap force-pushed the feat/dev-compatibility-for-monitoring branch from 261d13d to 17c65ca Compare November 15, 2023 13:54
amandine-sahl pushed a commit to PnX-SI/gn_module_monitoring that referenced this pull request Dec 8, 2023
Move migration alembic for "add_observers_txt_column_t_base_vist"
to GeoNature

See PR: PnX-SI/GeoNature#2692

Reviewed-by: andriacap
amandine-sahl pushed a commit to PnX-SI/gn_module_monitoring that referenced this pull request Dec 8, 2023
Move migration alembic for "add_observers_txt_column_t_base_vist"
to GeoNature

See PR: PnX-SI/GeoNature#2692

Reviewed-by: andriacap
@andriacap andriacap force-pushed the feat/dev-compatibility-for-monitoring branch from 17c65ca to 29a8c91 Compare January 15, 2024 08:36
@andriacap andriacap marked this pull request as ready for review January 15, 2024 08:51
@amandine-sahl amandine-sahl changed the base branch from develop to feat/monitoring_models July 29, 2024 07:40
Add component observers-txt to dynamic-form component

Reviewed-by: andriac
Fix set value `this.multiSelect` (always true before fixing)

Add multiselect option to component `pnx-observers`

Remove useless databing input for component `pnx-observers-text`

Reviewed-by: andriac
@amandine-sahl amandine-sahl force-pushed the feat/dev-compatibility-for-monitoring branch from 29a8c91 to 05d7787 Compare July 29, 2024 07:50
@amandine-sahl amandine-sahl merged commit e3c21cd into PnX-SI:feat/monitoring_models Jul 29, 2024
0 of 2 checks passed
amandine-sahl pushed a commit that referenced this pull request Jul 29, 2024
* feat: add option "null" in datalist form

Reviewed-by: andriacap

* feat: add nullDefault with multilist opt datalist

Reviewed-by: andriacap

* feat: add pnx-observers-text

Add component observers-txt to dynamic-form component

Reviewed-by: andriac

* feat: add multiselect databinding to observers

Fix set value `this.multiSelect` (always true before fixing)

Add multiselect option to component `pnx-observers`

Remove useless databing input for component `pnx-observers-text`

Reviewed-by: andriac

* rebase: rebase from develop and format

Reviewed-by: andriacap
amandine-sahl pushed a commit to PnX-SI/gn_module_monitoring that referenced this pull request Jul 29, 2024
Move migration alembic for "add_observers_txt_column_t_base_vist"
to GeoNature

See PR: PnX-SI/GeoNature#2692

Reviewed-by: andriacap
amandine-sahl added a commit to PnX-SI/gn_module_monitoring that referenced this pull request Oct 4, 2024
Use config instead of MonitoringPermissions_dict

Alter not null constraint for t_sites_groups, t_observations

Erreur rebase

Répercussion renomage de GNM en MONITORINGS et suppression de
MonitoringPermissions_dict

db: remove migration alembic

Move migration alembic for "add_observers_txt_column_t_base_vist"
to GeoNature

See PR: PnX-SI/GeoNature#2692

Reviewed-by: andriacap

Rename GNM to MONITORINGS

ux/ui: change layout home page monitoring

Remove two column (description/modules)
Align element from home page

Reviewed-by: andriac

fix: size of div container Acces site

Reviewed-by: andriacap

Correction tests

Black

pytest install monitoring module

Test if migration is run during installation or migration

refact: load all types site from btn-select comp

Basé sur les retours de Camille, Amandine et MNHN

Reviewed-by: andriac

style: apply lint frontend

Reviewed-by: andriacap

fix: specific field kept in form

Reset specific field when quit form component (entrance through site)

Reviewed-by: andriac

hotfix: problem create visit

Load permission on 'ALL' for modules error . Change to precise object
visit permission

Reviewed-by: andriac

style: centered protocol home page

Reviewed-by: andriacap

wip: manage geometry site group

Reviewed-by: andriac

fix:multiple layer and geom site group

Manage geometry site group (load, reload, on cancel, manage layer etc) (entrance through site)

Reviewed-by: andriac

feat: geom site group (edit and create)

Allow user to create and edit geometry for site group

Case :
- site group with child --> if no geom created, geometry is
  calculated
  --> if geom created you can edit this geom
- site group without child --> geom can be null (otherwise it's possible
  to create geom)

- Remove console.log

Reviewed-by: andriacap

ux: add message to inform about geom site group

Add message about geometry site group to infomr user that the current
geometry is calculated based on site group's child

Reviewed-by: andriacap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants