WIP: Add user configurable keybind to restart the overlay #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteFang5
reviewed
Oct 3, 2020
|
The However, there is one other thing I do deem necessary and that's the UI addition to allow users to change this keybind and/or properly enable/disable it. (Take a look at |
Gee19
force-pushed
the
feature/user_configurable_restart_keybind
branch
from
0c305bf
to
3ff72d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a user configurable keybind to restart the overlay.
This was something I was looking for (as well as a few other small things like my comment in #85) so why not give it a shot and get more familiar with the repo at the same time. Apologies if I am missing anything obvious, I am open to feedback from anyone.
Bonus:
How Has This Been Tested?
npm run ng:lintnpm run formatnpm run ng:testResources:
https://www.electronjs.org/docs/api/app#apprelaunchoptions