Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close #156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Auto-close #156

wants to merge 2 commits into from

Conversation

Bob343
Copy link

@Bob343 Bob343 commented Oct 6, 2020

Description

Added new setting to auto-close the search popup after mouse enters then leaves the search dialog. Defaults to false so keeping pre-existing functionality

Replication Steps

  1. Enable the setting
  2. Perform a search on any item
  3. Mouse over the dialog
  4. Move mouse out of the dialog
  5. Confirm dialog closes

How Has This Been Tested?

  • ran npm run ng:lint
  • ran npm run format
  • ran npm run ng:test
  • added unit tests
  • manually tested

return
}

if (this.data.settings.evaluateQueryAutoHideSearch && this.ref && this.ref.close)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use curly-brackets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants