Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add linux config for ci #28

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

add linux config for ci #28

wants to merge 16 commits into from

Conversation

kifers
Copy link
Collaborator

@kifers kifers commented Jun 13, 2020

Description

Replication Steps

Screenshots/Video

How Has This Been Tested?

  • ran npm run ng:lint
  • ran npm run format
  • ran npm run ng:test
  • added unit tests
  • manually tested

@kifers kifers added the work in progress Work is incomplete and should not be merged label Jun 13, 2020
ijemafe
ijemafe approved these changes Jun 13, 2020
View reviewed changes
Copy link

@ijemafe ijemafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to merge after resolving the conflict in .github/workflows/node.js.yml

@kifers
Copy link
Collaborator Author

kifers commented Jun 14, 2020

@ijemafe things aren't working just yet. There's an issue installing chrome on the docker container. Still need to work that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijemafe ijemafe ijemafe approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
work in progress Work is incomplete and should not be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kifers @ijemafe