Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the bLIP 10 Specification in this Repository #510

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

Alwin-Stockinger
Copy link
Contributor

@Alwin-Stockinger Alwin-Stockinger commented Apr 20, 2023

This PR addresses #506.

It also includes the action proposed in #500.

Changes to the original document:

  • Removed the blip number, title and status from the heading and changed Author to Original Author
  • Modified the abstract to better fit with the rest of Podcasting 2.0
  • Turned codeblocks into json codeblocks
  • Corrected the Example in the Abstract to a valid json with double quotes instead of single quotes
  • Made the “Formatting and encoding” section a little clearer
  • Made clear that multiple fields for identifying podcast and episode can be added
  • Added guid to “use any of podcastfeedID or url
  • Made episode_guid preferred field for identifying episode because episode_guid does not rely on the episode being in the index
  • Put tsabove time to reflect that ts is preferred
  • Add auto option to action, as was proposed by @dhk2 in Adding "auto" as one of the action: types for Boostagrams #500
  • Added to boost_link field description that it can be used for any action and that links may not contain podcast, episode AND timestamp, as Fountain currently only links to the episode not a timestamp.
  • Switched recommended from name to sender_name because the receiver should know the name of their split anyway, but not the one of the sender
  • Reformulated sender_id description
  • Removed pubkey, seconds_back, sender_key, sig_fields, signature fields because no app is using them (Podverse sends the pubkey field but only puts the value “podverse-pubkey" in it)
  • Removed value_msat because that information is in the invoice anyways
  • Made value_msat_total recommended for numerology purposes
  • Removed Motivation section
  • Removed Rationale section
  • Removed Universality section
  • Removed Backwards Compatibility section
  • Added Rust-V4V to Reference Implementations
  • Added Examples & App Specifics section

@satoshisstream
Copy link
Contributor

Good idea to remove the old/unused things.

satoshisstream added a commit to satoshisstream/blips that referenced this pull request Apr 20, 2023
Removing unused properties, clearing up fields, adding the `auto` option.

More info: Podcastindex-org/podcast-namespace#510
@satoshisstream
Copy link
Contributor

lightning/blips#23

@Alwin-Stockinger
Copy link
Contributor Author

lightning/blips#23

Is there any automatic way we could keep both of them in sync somehow?

@satoshisstream
Copy link
Contributor

Just link it I'd say; anyone can PR the lightning repo :)

@daveajones daveajones merged commit 60b02f8 into Podcastindex-org:main Apr 20, 2023
@daveajones
Copy link
Contributor

Thanks for this. Much easier to track now.

ericpp added a commit to ericpp/podcast-namespace that referenced this pull request Nov 25, 2023
ericpp added a commit to ericpp/podcast-namespace that referenced this pull request Nov 25, 2023
ericpp added a commit to ericpp/podcast-namespace that referenced this pull request Nov 25, 2023
ericpp added a commit to ericpp/podcast-namespace that referenced this pull request Nov 25, 2023
ericpp added a commit to ericpp/podcast-namespace that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants