Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments: reply to comments on the podcast page #233

Open
dellagustin opened this issue Feb 15, 2023 · 2 comments
Open

Comments: reply to comments on the podcast page #233

dellagustin opened this issue Feb 15, 2023 · 2 comments

Comments

@dellagustin
Copy link
Contributor

dellagustin commented Feb 15, 2023 •
edited
Loading

I'm creating this issue to start documenting options for how we could implement support for commenting or replying to comments from the podcasts page.

Related issues, PRs and general links
@dellagustin
Copy link
Contributor Author

See #228 (comment)

@dellagustin dellagustin mentioned this issue Feb 21, 2023
Closed
@dellagustin dellagustin mentioned this issue Mar 4, 2023
Closed
dellagustin added a commit to podStation/podcastindex-web-ui that referenced this issue Apr 19, 2023
@dellagustin @nathangathright
Enhancements Podcastindex-org#240, Podcastindex-org#233 Comments repl…
40e8e99 
…y and other actions

This commit implements Podcastindex-org#240 and initial support for Podcastindex-org#233.

A menu is added to comments that support initiating the following
actions:
- Reply to post - currently just navigates to the post in it is
  original system
- Copy link to post
- Open in original site - opens the post in its original system at
  another tab
- Follow author of the post - currently just navigates to the
  profile of the author on its original system

This commit is based on
nathangathright/comment-thread-mockup@6b2f716

Related issues:

- Podcastindex-org#240
- Podcastindex-org#233

Co-authored-by: Nathan Gathright <[email protected]>
@dellagustin dellagustin mentioned this issue Apr 19, 2023
Merged
dellagustin added a commit to podStation/podcastindex-web-ui that referenced this issue Apr 30, 2023
@dellagustin
Comments: Podcastindex-org#233 Remote interaction
7f59726 
This commit implements one next step to automate the remote
interactions with comments and commenters.

This uses the WebFinger protocol and API and also the
OStatus Subscribe mechanism.

There are very little guardrails, so some might need to
be implemented later (e.g. verifying the input for the
interactor account).

Known issues:
When the user is first prompted to enter their account,
the opening of a new tab for interaction will be blocked
as a pop-up.

Related issues:
- Podcastindex-org#233
- Podcastindex-org#240

Related links:
-
https://socialhub.activitypub.rocks/t/represent-endpoint-for-remote-interaction/480
dellagustin added a commit to podStation/podcastindex-web-ui that referenced this issue May 7, 2023
@dellagustin @stevencrader
PR Review Podcastindex-org#233 - Comments - fix attribute errors
09396eb 
References:
-
Podcastindex-org#253 (comment)

Co-authored-by: Steven Crader <[email protected]>
daveajones added a commit that referenced this issue May 11, 2023
@daveajones
Merge pull request #253 from podStation/enhancement#233__reply-to-com…
32b2bf5 
…ments

Enhancements #240, #233 Comments reply and other actions
@dellagustin dellagustin changed the title DRAFT - Comment / reply to comments on the podcast page Comment / reply to comments on the podcast page May 13, 2023
@dellagustin
Copy link
Contributor Author

Partially implemented with #218.
The future vision for this is that replies could be posted directly from the index. That is a major implementation though.
I'm not sure if and when I'm tackling it.

@dellagustin dellagustin changed the title Comment / reply to comments on the podcast page Comments: reply to comments on the podcast page May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dellagustin