Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /api/comments/byepisodeid to handle episode without a socialInteract #266

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

stevencrader
Copy link
Collaborator

Resolves #265

@stevencrader
Copy link
Collaborator Author

@dellagustin can you look at this?

@dellagustin
Copy link
Contributor

Hello @stevencrader , how did you test this? Directly calling the /api/comments/byepisodeid endpoint?
As far as I know, if socialInteract is not used by an episode, the Show comments button will not be shown.
Of course, it should be fixed regardless, but I just wanted to know if this is actually a bug observed during a regular user journey, or something that is only a "sanity check" fix.

@stevencrader
Copy link
Collaborator Author

Hi @dellagustin. I did call it directly.

I noticed there was a typo in length and wanted to verify it was a real issue and then test my fix.

I agree that the logic before won't call this if there isn't a socialInteract tag do it isn't that big of an issue.

@dellagustin
Copy link
Contributor

It should fix #232 as well, same as #265.
I'll run a quick test.

server/index.js Outdated Show resolved Hide resolved
Co-authored-by: Guilherme Dellagustin <[email protected]>
@dellagustin
Copy link
Contributor

dellagustin commented May 18, 2023

@daveajones Looks good to me now.
I recommend using Squash and merge for this one.

@daveajones daveajones merged commit 1eefc5f into Podcastindex-org:master Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Episode with invalid socialInteract not handled properly
3 participants