Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Feature/2 create knowledge category #15

Merged
merged 28 commits into from
Sep 28, 2024
Merged

Merge Feature/2 create knowledge category #15

merged 28 commits into from
Sep 28, 2024

Conversation

TSampley
Copy link
Contributor

Resolves #2

@TSampley
remove google run project file
460c728
@TSampley
replace placeholder text in API
f8e55b3
@TSampley
remove artifact registry
d1b4bb0
@TSampley
Upgrade koin
b33da10
@TSampley
Add mockk to jvmSharedTest source set
fd2b43f
@TSampley
Add setupKoin function for platforms
3632bcc
@TSampley
replace explicit startKoin with setupKoin function
f9c3af8
@TSampley
checkmodule of koin application
388f758
@TSampley
Add editor state enum
d6ee564
@TSampley
Add category editor test case
bf70b2e
@TSampley
Add category editor view model to explorer view model
524e91c
@TSampley
replace explicit construction with inline constructor reference
c78b7a9
@TSampley
replace concept editor view model explicit constructor with inline bi…
5fcbe54 
…nding
@TSampley
replace category editor view model explicit constructor with inline b…
db128f9 
…inding
@TSampley
remove category creator view model binding
452fd9e
@TSampley
Swap concept creator view model for editor view model
2071e84
@TSampley
implement category editor view model based on creator view model
ee7e7c7
@TSampley
rename CategoryCreator.kt -> -Editor
4c29d69
@TSampley
Add CategoryEditor to explorer Screen
b134830 
* replace nullable editor state with sealed interface
@TSampley
Remove implementation by delegation
bc480a7 
1. Simplify concept editor view model signatures
2. Do not inherit from ConceptEditorViewModel or CategoryEditorViewModel
3. Define concept/category-specific functions in this class
@TSampley
Add expected content description
1838a16
@TSampley
Fix wrong state set
f664c5d
@TSampley
fix confirmation button with wrong text
828d51e
@TSampley
observe finish events
ce24da4
@TSampley
wrap category editor in dialog
0a73528
@TSampley
move dialogs below constant UI
7b51f38
@TSampley
Create negative test cases
ff72e45
@TSampley TSampley linked an issue Sep 28, 2024 that may be closed by this pull request
Create Knowledge Category #2
Closed
9 tasks
@TSampley TSampley self-assigned this Sep 28, 2024
@TSampley TSampley enabled auto-merge (squash) September 28, 2024 20:18
@TSampley TSampley merged commit ca39505 into main Sep 28, 2024
1 check passed
@TSampley TSampley deleted the feature/2-create-knowledge-category branch September 28, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TSampley TSampley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Knowledge Category
1 participant
@TSampley