Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Feature/39 feature deliver rider to destination #53

Merged
merged 94 commits into from
Sep 23, 2024
Merged

Merge Feature/39 feature deliver rider to destination #53

merged 94 commits into from
Sep 23, 2024

Conversation

TSampley
Copy link
Contributor

Resolves #39

@TSampley
move test file to coreLocalTestModule function
0892ffa
@TSampley
Add production/testing notes
914d38f
@TSampley
Add appModule doc
f670875
@TSampley
Replace manual koin setup with application setup function
7b18f31
@TSampley
Create KoinExt to simplify test setup
2b3a48b
@TSampley
replace manual koin setup with extension function
04e8654
@TSampley
Fix shared package identifiers
c2675a7
@TSampley
replace manual koin configuration with setup function
015d934
@TSampley
Move test bindings out to feature test koin modules
e692488
@TSampley
Replace explicit construction of TestRideRepository with consistent k…
61ba82e 
…oin configuration
@TSampley
rename repository for role ownership clarity
a6b8b78
@TSampley
Clean up unused imports
70ba97f
@TSampley
Fix test docs
f62f961
@TSampley
remove empty test
299b289
@TSampley
move drive/ride tests to package directory
13035b6
@TSampley
remove empty test
c32da9b
@TSampley
move koin retrieval below complete setup
5d2a39f
@TSampley
Move common dependencies to setUp block
a09b6bf
@TSampley
Rename screen/state/viewmodel with Provider over Driver
a567f19
@TSampley
Update roles in README to reflect preferred terminology
b76d684
@TSampley
Add provider dashboard view model
ff41e99
@TSampley
rename file to match composable
51f9156
@TSampley
Fix doc
c3e51fd
@TSampley
Rename uis and models to reflect preferred terminology
73edbe7 
* Provider
* Passenger
* Trip
@TSampley
rename tests/files with preferred term
874b427
@TSampley
rename test/file with preferred term
d394220
@TSampley
replace "ride request" with "trip request"
56e867e
@TSampley
Fix test repo not found by koin
8106331 
* cast DriverRideRepository as TestDriverRideRepository
@TSampley
Add test actions/expectations comments
accb5a1
@TSampley
Add new location service
6343b9b
@TSampley
Fix wrong arc-trig function used to calculate great angle
9eadc73
@TSampley
Remove flaky wait
6d7388c
@TSampley
tighten calculation expectations slightly
692c3e4
@TSampley
Watch distance to drop off point after picking up rider
79d6dc6
@TSampley
Add drop off event
48f3a4d
@TSampley
Display delivery information
c7cc713
@TSampley
Add blank completion info view
8dd99e0
@TSampley
Fix wrong text string
c39fdc6
@TSampley
reorganize expectations
0abf988
@TSampley
move distance watcher after mutable state update
fae37e0
@TSampley
fix active ride not being set
b12cd5a
@TSampley
remove redundant text
fd44d3e
@TSampley
provide trip completion view model event
85ef2a0
@TSampley
dispose any jobs when view model is disposed
a67239a
@TSampley
Add base view model doc
e0b8d43
@TSampley
modify doc
ab63015
@TSampley
add trip completion view
85b2e26
@TSampley
Finish test expectations
efd2589
@TSampley
print stack traces on unexpected conditions
3dc716e
@TSampley
Add complete function to skip CompletingRide state
1ec2256
@TSampley
expand accepted types to Active/CompletionRide
a5b31b2
@TSampley
Fix provider/passenger references in error strings
20ce004
@TSampley
Add documentation about skipped state
092ae39
@TSampley
Add test todo
e00ebc7
@TSampley
restore test repository in koin graph for request ride ui test
eeedb48
@TSampley TSampley added this to the Basic Rides milestone Sep 23, 2024
@TSampley TSampley linked an issue Sep 23, 2024 that may be closed by this pull request
[FEATURE] Deliver Rider to Destination #39
Closed
4 tasks
@TSampley TSampley enabled auto-merge (squash) September 23, 2024 03:11
@TSampley TSampley merged commit a366467 into main Sep 23, 2024
2 checks passed
@TSampley TSampley deleted the feature/39-feature-deliver-rider-to-destination branch September 23, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Basic Rides
Development

Successfully merging this pull request may close these issues.

[FEATURE] Deliver Rider to Destination
1 participant
@TSampley