Length zero fix #1030
Open
Length zero fix #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/sample_swap.R
Outdated
|
|
||
| if(nrow(filtered_sample_pair) > 0){ | ||
| unique(unlist(filtered_sample_pair[XY_possibly_paired == "Yes", .(X_bam, Y_bam)], use.names = FALSE)) | ||
| } | ||
| } | ||
| }) | ||
| pos_mathces = pos_mathces[which(lapply(pos_mathces, function(x) length(x) > 0) == TRUE)] |
There was a problem hiding this comment.
It should be better to use pos_mathces[sapply(pos_mathces, function(x) length(x) > 0)]?
There was a problem hiding this comment.
Yes, you are right. That works as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @PoisonAlien,
When filtering sample pair at
if(nrow(sample_pair) > 0){ unique(unlist(sample_pair[XY_possibly_paired == "Yes", .(X_bam, Y_bam)], use.names = FALSE)) }, the script fails if nrow is of length zero. This PR fixes this.It also fixes issues described in PR #797
I've tested it on real data but please take a look.
Thanks