Icon rework for flying robots.

code/game/objects/effects/decals/Cleanable/robots.dm

@@ -1,7 +1,7 @@
 /obj/effect/decal/cleanable/blood/gibs/robot
 	name = "robot debris"
 	desc = "It's a useless heap of junk... <i>or is it?</i>"
-	icon = 'icons/mob/robots.dmi'
+	icon = 'icons/mob/robot_gibs.dmi'
 	icon_state = "gib1"
 	basecolor = SYNTH_BLOOD_COLOUR
 	random_icon_states = list("gib1", "gib2", "gib3", "gib4", "gib5", "gib6", "gib7")

code/game/objects/effects/decals/remains.dm

@@ -14,7 +14,7 @@
 
 /obj/effect/decal/remains/robot
 	desc = "They look like the remains of something mechanical. They have a strange aura about them."
-	icon = 'icons/mob/robots.dmi'
+	icon = 'icons/mob/robot_gibs.dmi'
 	icon_state = "remainsrobot"
 
 /obj/effect/decal/remains/mouse

code/modules/mob/living/silicon/robot/robot.dm

@@ -3,7 +3,7 @@
 /mob/living/silicon/robot
 	name = "Cyborg"
 	real_name = "Cyborg"
-	icon = 'icons/mob/robots.dmi'
+	icon = 'icons/mob/robots/robots_grounded.dmi'
 	icon_state = "robot"
 	maxHealth = 200
 	health = 200

code/modules/mob/living/silicon/robot/robot_modules/_module.dm

@@ -154,11 +154,19 @@
 		R.radio.recalculateChannels()
 	R.choose_icon(0, R.set_module_sprites(list("Default" = "robot")))
 
+// This can qdel before init if spawned outside a mob, so
+// Destroy() needs to be a bit nuanced to avoid runtimes.
 /obj/item/robot_module/Destroy()
-	QDEL_NULL_LIST(modules)
-	QDEL_NULL_LIST(synths)
-	QDEL_NULL(emag)
-	QDEL_NULL(jetpack)
+	for(var/datum/thing in modules)
+		qdel(thing)
+	modules = null
+	for(var/datum/thing in synths)
+		qdel(thing)
+	synths = null
+	if(istype(emag))
+		QDEL_NULL(emag)
+	if(istype(jetpack))
+		QDEL_NULL(jetpack)
 	return ..()
 
 /obj/item/robot_module/emp_act(severity)

code/modules/mob/living/silicon/robot/robot_modules/event.dm

@@ -3,6 +3,7 @@
 // The module that borgs on the surface have.  Generally has a lot of useful tools in exchange for questionable loyalty to the crew.
 /obj/item/robot_module/robot/lost
 	name = "lost robot module"
+	module_category = ROBOT_MODULE_TYPE_FLYING
 	unavailable_by_default = TRUE
 	hide_on_manifest = TRUE
 	sprites = list(
@@ -35,11 +36,11 @@
 
 /obj/item/robot_module/robot/gravekeeper
 	name = "gravekeeper robot module"
+	display_name = "Gravekeeper"
 	unavailable_by_default = TRUE
 	hide_on_manifest = TRUE
 	sprites = list(
-		"Drone" = "drone-gravekeeper",
-		"Sleek" = "sleek-gravekeeper"
+		"Gravekeeper" = "sleek-gravekeeper"
 	)
 	modules = list(
 		/obj/item/melee/baton/shocker/robot,

code/modules/mob/living/silicon/robot/robot_modules/station.dm

@@ -14,7 +14,6 @@
 		"Android"          = "droid",
 		"Insekt"           = "insekt-Default",
 		"Usagi-II"         = "tall2standard",
-		"Pyralis"          = "Glitterfly-Standard",
 		"Decapod"          = "decapod-Standard",
 		"Pneuma"           = "pneuma-Standard",
 		"Tower"            = "drider-Standard"
@@ -30,6 +29,8 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
+		"Drone"   = "drone-standard",
+		"Pyralis" = "Glitterfly-Standard",
 		"Cabeiri" = "eyebot-standard"
 	)
 
@@ -55,10 +56,8 @@
 		"Basic"            = "Medbot",
 		"Advanced Droid"   = "droid-medical",
 		"Needles"          = "medicalrobot",
-		"Handy"            = "handy-med",
 		"Insekt"           = "insekt-Med",
 		"Usagi-II"         = "tall2medical",
-		"Pyralis"          = "Glitterfly-Surgeon",
 		"Decapod"          = "decapod-Surgeon",
 		"Pneuma"           = "pneuma-Surgeon",
 		"Tower"            = "drider-Surgeon"
@@ -93,8 +92,10 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
-		"Drone"  = "drone-medical",
-		"Eyebot" = "eyebot-medical"
+		"Handy"   = "handy-med",
+		"Drone"   = "drone-medical",
+		"Eyebot"  = "eyebot-medical",
+		"Pyralis" = "Glitterfly-Surgeon"
 	)
 
 /obj/item/robot_module/robot/medical/surgeon/finalize_emag()
@@ -145,7 +146,6 @@
 		"Needles"          = "medicalrobot",
 		"Insekt"           = "insekt-Med",
 		"Usagi-II"         = "tall2medical",
-		"Pyralis"          = "Glitterfly-Crisis",
 		"Decapod"          = "decapod-Crisis",
 		"Pneuma"           = "pneuma-Crisis",
 		"Tower"            = "drider-Crisis"
@@ -174,8 +174,9 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
-		"Drone"  = "drone-medical",
-		"Eyebot" = "eyebot-medical"
+		"Drone"   = "drone-medical",
+		"Eyebot"  = "eyebot-medical",
+		"Pyralis" = "Glitterfly-Crisis"
 	)
 
 /obj/item/robot_module/robot/medical/crisis/finalize_emag()
@@ -233,9 +234,7 @@
 		"Landmate"           = "landmate",
 		"Landmate - Treaded" = "engiborg+tread",
 		"Treadwell"          = "treadwell",
-		"Handy"              = "handy-engineer",
 		"Usagi-II"           = "tall2engineer",
-		"Pyralis"            = "Glitterfly-Engineering",
 		"Decapod"            = "decapod-Engineering",
 		"Pneuma"             = "pneuma-Engineering",
 		"Tower"              = "drider-Engineering"
@@ -322,8 +321,10 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
-		"Drone"  = "drone-engineer",
-		"Eyebot" = "eyebot-engineering"
+		"Handy"   = "handy-engineer",
+		"Drone"   = "drone-engineer",
+		"Eyebot"  = "eyebot-engineering",
+		"Pyralis" = "Glitterfly-Engineering",
 	)
 
 /obj/item/robot_module/robot/security
@@ -358,7 +359,6 @@
 		"Black Knight"       = "securityrobot",
 		"Insekt"             = "insekt-Sec",
 		"Usagi-II"           = "tall2security",
-		"Pyralis"            = "Glitterfly-Security",
 		"Decapod"            = "decapod-Security",
 		"Pneuma"             = "pneuma-Security",
 		"Tower"              = "drider-Security"
@@ -368,8 +368,9 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
-		"Drone"  = "drone-sec",
-		"Eyebot" = "eyebot-security"
+		"Pyralis" = "Glitterfly-Security",
+		"Drone"   = "drone-sec",
+		"Eyebot"  = "eyebot-security"
 	)
 
 /obj/item/robot_module/robot/security/respawn_consumable(var/mob/living/silicon/robot/R, var/amount)
@@ -402,7 +403,6 @@
 		"Mopbot"           = "janitorrobot",
 		"Mop Gear Rex"     = "mopgearrex",
 		"Usagi-II"         = "tall2janitor",
-		"Pyralis"          = "Glitterfly-Janitor",
 		"Decapod"          = "decapod-Janitor",
 		"Pneuma"           = "pneuma-Janitor",
 		"Tower"            = "drider-Janitor"
@@ -419,7 +419,9 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
-		"Cabeiri" = "eyebot-janitor",
+		"Drone"   = "drone-janitor",
+		"Pyralis" = "Glitterfly-Janitor",
+		"Cabeiri" = "eyebot-janitor"
 	)
 
 /obj/item/robot_module/robot/janitor/finalize_emag()
@@ -475,7 +477,6 @@
 		"Bro"              = "Brobot",
 		"Rich"             = "maximillion",
 		"Usagi-II"         = "tall2service",
-		"Pyralis"          = "Glitterfly-Service",
 		"Decapod"          = "decapod-Service",
 		"Pneuma"           = "pneuma-Service",
 		"Tower"            = "drider-Service"
@@ -503,6 +504,7 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
+		"Pyralis"           = "Glitterfly-Service",
 		"Eyebot"            = "eyebot-standard",
 		"Service Drone"     = "drone-service",
 		"Hydroponics Drone" = "drone-hydro"
@@ -541,7 +543,6 @@
 		"Rich"             = "maximillion",
 		"Default"          = "Service2",
 		"Usagi-II"         = "tall2service",
-		"Pyralis"          = "Glitterfly-Clerical",
 		"Decapod"          = "decapod-Clerical",
 		"Pneuma"           = "pneuma-Clerical",
 		"Tower"            = "drider-Clerical"
@@ -562,7 +563,8 @@
 	sprites = list(
 		"Eyebot"            = "eyebot-standard",
 		"Service Drone"     = "drone-service",
-		"Hydroponics Drone" = "drone-hydro"
+		"Hydroponics Drone" = "drone-hydro",
+		"Pyralis"           = "Glitterfly-Clerical"
 	)
 
 /obj/item/robot_module/general/butler/respawn_consumable(var/mob/living/silicon/robot/R, var/amount)
@@ -588,7 +590,6 @@
 		"Advanced Droid"    = "droid-miner",
 		"Treadhead"         = "Miner",
 		"Usagi-II"          = "tall2miner",
-		"Pyralis"           = "Glitterfly-Miner",
 		"Decapod"           = "decapod-Miner",
 		"Pneuma"            = "pneuma-Miner",
 		"Tower"             = "drider-Miner"
@@ -609,7 +610,9 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
-		"Cabeiri" = "eyebot-miner"
+		"Drone"   = "drone-miner",
+		"Cabeiri" = "eyebot-miner",
+		"Pyralis" = "Glitterfly-Miner"
 	)
 
 /obj/item/robot_module/robot/research
@@ -622,10 +625,8 @@
 		"WTDove"     = "whitespider",
 		"WTOperator" = "sleekscience",
 		"Droid"      = "droid-science",
-		"Handy"      = "handy-science",
 		"Insekt"     = "insekt-Sci",
 		"Usagi-II"   = "tall2peace",
-		"Pyralis"    = "Glitterfly-Research",
 		"Decapod"    = "decapod-Research",
 		"Pneuma"     = "pneuma-Research",
 		"Tower"      = "drider-Research"
@@ -668,6 +669,9 @@
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	can_be_pushed = TRUE
 	sprites = list(
+		"Handy"   = "handy-science",
+		"Drone"   = "drone-science",
+		"Pyralis" = "Glitterfly-Research",
 		"Cabeiri" = "eyebot-science"
 	)
 

code/modules/mob/living/silicon/robot/subtypes/flying.dm

@@ -1,6 +1,6 @@
 /mob/living/silicon/robot/flying
 	desc = "A utility robot with an anti-gravity hover unit and a lightweight frame."
-	icon = 'icons/mob/robots_flying.dmi'
+	icon = 'icons/mob/robots/robots_flying.dmi'
 	icon_state = "drone-standard"
 	module_category = ROBOT_MODULE_TYPE_FLYING
 	dismantle_type = /obj/item/robot_parts/frame/flyer

code/modules/mob/living/silicon/robot/subtypes/gravekeeper.dm

@@ -11,17 +11,12 @@
 
 /mob/living/silicon/robot/gravekeeper/init()
 	aiCamera = new/obj/item/camera/siliconcam/robot_camera(src)
-
 	mmi = new /obj/item/mmi/digital/robot(src)
 	module = new /obj/item/robot_module/robot/gravekeeper(src)
 	cut_overlays()
 	init_id()
-
 	updatename("Gravekeeper")
-
 	if(!cell)
 		cell = new /obj/item/cell/high(src) // 15k cell, as recharging stations are a lot more rare on the Surface.
-
 	laws = new /datum/ai_laws/gravekeeper()
-
 	playsound(src, 'sound/mecha/nominalsyndi.ogg', 75, 0)

code/modules/mob/living/silicon/robot/subtypes/thinktank/_thinktank.dm

@@ -1,7 +1,7 @@
 /mob/living/silicon/robot/platform
 	name = "support platform"
 	desc = "A large quadrupedal AI platform, colloquially known as a 'think-tank' due to the flexible onboard intelligence."
-	icon = 'icons/mob/robots_thinktank.dmi'
+	icon = 'icons/mob/robots/robots_platform.dmi'
 	icon_state = "tachi"
 	color = "#68a2f2"
 

code/modules/mob/living/silicon/robot/subtypes/thinktank/thinktank_module.dm

@@ -1,14 +1,13 @@
 /obj/item/robot_module/robot/platform
 
-	hide_on_manifest = TRUE
 	module_category = ROBOT_MODULE_TYPE_PLATFORM
 	unavailable_by_default = TRUE
 
 	var/pupil_color =     COLOR_CYAN
 	var/base_color =      COLOR_WHITE
 	var/eye_color =       COLOR_BEIGE
 	var/armor_color =    "#68a2f2"
-	var/user_icon =       'icons/mob/robots_thinktank.dmi'
+	var/user_icon =       'icons/mob/robots/robots_platform.dmi'
 	var/user_icon_state = "tachi"
 
 	var/list/decals

code/modules/xenoarcheaology/finds/find_spawning.dm

@@ -424,7 +424,7 @@
 			//robot remains
 			apply_prefix = FALSE
 			item_type = "[pick("mechanical","robotic","cyborg")] [pick("remains","chassis","debris")]"
-			icon = 'icons/mob/robots.dmi'
+			icon = 'icons/mob/robot_gibs.dmi'
 			icon_state = "remainsrobot"
 			additional_desc = pick("Almost mistakeable for the remains of a modern cyborg.",\
 			"They are barely recognisable as anything other than a pile of waste metals.",\