Fix get_policy_search endpoint to return 404 when no policy is found
#1854
Conversation
There was a problem hiding this comment.
Hi @tawandamoyo, thanks for your work on this. I had a couple of recommended changes, but looking forward to merging this down the road.
policyengine_api/endpoints/policy.py
Outdated
| message=f"Database query failed for {country_id} with query '{query}", | ||
| ) | ||
| return Response( | ||
| json.dumps(body), status=500, mimetype="application/json" |
There was a problem hiding this comment.
| json.dumps(body), status=500, mimetype="application/json" | |
| json.dumps(body), status=404, mimetype="application/json" |
See above on why I say 404 is better here than 500
tawandamoyo
force-pushed
the
fix/416-status-response-where-no-country-policy
branch
from
7c05cd9
to
3010ed0
Compare
There was a problem hiding this comment.
Hi @tawandamoyo, thanks for your adjustments to this. One last thing - I think we should send the error message as a part of the response, and I've added the typical method of doing so as a suggestion. After that, this will be good to go.
policyengine_api/endpoints/policy.py
Outdated
| return Response( | ||
| json.dumps(body), status=200, mimetype="application/json" | ||
| ) | ||
| except: |
There was a problem hiding this comment.
| except: | |
| except Exception as e: |
One minor thing - we can actually return the error message with the response, so I think that'd be for the best.
tawandamoyo
force-pushed
the
fix/416-status-response-where-no-country-policy
branch
from
3010ed0
to
22fb8c3
Compare
There was a problem hiding this comment.
Thanks for these changes @tawandamoyo! It'll be great to have these.
Fixes #416
Changes
get_policy_search