Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clickability to initial microsim outputs #2014

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tawandamoyo
Copy link
Contributor

@tawandamoyo tawandamoyo commented Sep 16, 2024

Fixes #1939

Changes

Added clickability to inital microsim outputs.

Screenshots

add-clickability.mp4

With hover (update)

clickability-hover.mp4

@anth-volk
Copy link
Collaborator

This is looking good! One thing I'd recommend is underlining the relevant clickable portion. I'd be curious, if you don't mind, if you could work that up and share a video of it so we can see what it might look like.

@tawandamoyo
Copy link
Contributor Author

This is looking good! One thing I'd recommend is underlining the relevant clickable portion. I'd be curious, if you don't mind, if you could work that up and share a video of it so we can see what it might look like.

This is what it looks like with underline.

underline

@anth-volk
Copy link
Collaborator

Wow, that does not look good haha. I think it'd be great to somehow indicate to the user that these lines of text are clickable, but it not be ugly. Any ideas?

@tawandamoyo
Copy link
Contributor Author

Wow, that does not look good haha. I think it'd be great to somehow indicate to the user that these lines of text are clickable, but it not be ugly. Any ideas?

Maybe add some (light gray/gray?) hover effect?

@anth-volk
Copy link
Collaborator

Would you mind trying that out and recording it to see how it looks? In the style or styles folder, there are a series of color constants that I think would be best to utilize here.

@tawandamoyo
Copy link
Contributor Author

Would you mind trying that out and recording it to see how it looks? In the style or styles folder, there are a series of color constants that I think would be best to utilize here.

here with hover:

clickability-hover.mp4

@anth-volk
Copy link
Collaborator

Would you mind making this so the following is true:

  • The highlighting doesn't extend beyond the top or bottom of the words
  • The color is a pale version of one of our blues, as opposed to gray
  • The hovering doesn't move the text around; right now, when you hover, it shifts everything else downward, too

Thanks for your continued work on this, @tawandamoyo!

@tawandamoyo
Copy link
Contributor Author

Would you mind making this so the following is true:

  • The highlighting doesn't extend beyond the top or bottom of the words
  • The color is a pale version of one of our blues, as opposed to gray
  • The hovering doesn't move the text around; right now, when you hover, it shifts everything else downward, too

Thanks for your continued work on this, @tawandamoyo!

pale-blue-bg.mp4

@anth-volk anth-volk self-requested a review September 24, 2024 15:42
@anth-volk
Copy link
Collaborator

Thanks for this @tawandamoyo, it's looking good. If you feel this is ready, could you move it out of draft? And I'd just love confirmation on the design from @MaxGhenis, as he is much more user-facing, before reviewing/approving.

@anth-volk
Copy link
Collaborator

@MaxGhenis Hoping for your opinion on this

@MaxGhenis
Copy link
Contributor

I like it! Could we bold the text on hover? We do that for other similar elements like the left menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting Response
Development

Successfully merging this pull request may close these issues.

Make the three initial Microsim outputs clickable
3 participants