Nova Scotia Pension Income Amount #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PolicyEngine#473 Add initial param, var, test
PavelMakarchuk
requested changes
Dec 3, 2023
..._canada/parameters/gov/provinces/ns/tax/income/credits/pension_income_amount/max_amount.yaml
Outdated
Show resolved
Hide resolved
..._canada/parameters/gov/provinces/ns/tax/income/credits/pension_income_amount/max_amount.yaml
Outdated
Show resolved
Hide resolved
..._canada/parameters/gov/provinces/ns/tax/income/credits/pension_income_amount/max_amount.yaml
Outdated
Show resolved
Hide resolved
..._canada/parameters/gov/provinces/ns/tax/income/credits/pension_income_amount/max_amount.yaml
Outdated
Show resolved
Hide resolved
..._canada/parameters/gov/provinces/ns/tax/income/credits/pension_income_amount/max_amount.yaml
Outdated
Show resolved
Hide resolved
policyengine_canada/tests/gov/provinces/ns/tax/income/credits/ns_pension_income_amount
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_pension_income_amount
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_pension_income_amount
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_pension_income_amount
Outdated
Show resolved
Hide resolved
policyengine_canada/tests/gov/provinces/ns/tax/income/credits/ns_pension_income_amount
Outdated
Show resolved
Hide resolved
Fixes PolicyEngine#473 rename max_amount to cap and add one more test
PavelMakarchuk
approved these changes
Dec 10, 2023
MaxGhenis
requested changes
Dec 11, 2023
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_pension_income_amount.py
Outdated
Show resolved
Hide resolved
...yengine_canada/parameters/gov/provinces/ns/tax/income/credits/pension_income_amount/cap.yaml
Outdated
Show resolved
Hide resolved
Fixes PolicyEngine#473 Add details of reference
MaxGhenis
requested changes
Jan 10, 2024
PavelMakarchuk
requested changes
Jan 17, 2024
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_pension_income_amount.py
Outdated
Show resolved
Hide resolved
policyengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_pension_income_amount.py
Outdated
Show resolved
Hide resolved
...yengine_canada/parameters/gov/provinces/ns/tax/income/credits/pension_income_amount/cap.yaml
Show resolved
Hide resolved
Fixes PolicyEngine#473 Small fix
@MaxGhenis we will create a new PR to create the net income tree of NS once the open PR's are merged, since we have not followed this practice early in the development the credits are scattered in the repo. |
MaxGhenis
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#473
Add pension amount for Nova Scotia