-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kansas Additional Exemption for Disabled Veterans 2023 #5052
Conversation
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/veterans_matched.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/tests/policy/baseline/gov/states/ks/tax/income/exemptions/ks_exemptions.yaml
Outdated
Show resolved
Hide resolved
...ables/gov/states/ks/tax/income/exemptions/disabled_veteran/ks_disabled_veteran_exemptions.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
...ov/states/ks/tax/income/exemptions/disabled_veteran/ks_disabled_veteran_exemptions_person.py
Outdated
Show resolved
Hide resolved
...ables/gov/states/ks/tax/income/exemptions/disabled_veteran/ks_disabled_veteran_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ks/tax/income/exemptions/ks_exemptions.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
policyengine_us/variables/gov/states/ks/tax/income/exemptions/ks_exemptions.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ks/tax/income/exemptions/ks_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ks/tax/income/exemptions/ks_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/disabled_veteran.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/disabled_veteran.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/disabled_veteran.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5052 +/- ##
=======================================
Coverage 99.12% 99.13%
=======================================
Files 2592 2601 +9
Lines 37707 37805 +98
Branches 162 160 -2
=======================================
+ Hits 37378 37477 +99
+ Misses 297 296 -1
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
...ne_us/variables/gov/states/ks/tax/income/exemptions/ks_disabled_veteran_exemptions_person.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/disabled_veteran.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxGhenis
we have been using veterans_benefits > 0
for the determination of whether the person is a veteran or not, I think adding a bool variable would be appropriate given how we handle other situations like parent etc.
thoughts?
@hua7450 if confirmed
could we add a formula to check if veterans_benefits > 0
and file an issue to consolidate in the rest of the repo
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor format
@@ -0,0 +1,15 @@ | |||
description: Kansas provides the following exemption amount for disabled veterans. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: Kansas provides the following exemption amount for disabled veterans. | |
description: Kansas provides the following exemption amount for each disabled veteran. |
value_type = bool | ||
entity = Person | ||
label = "Eligible person for the Kansas disabled veteran exemption" | ||
unit = USD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit = USD |
Fixes #4969