Kansas Additional Exemption for Disabled Veterans 2023 #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelMakarchuk
requested changes
Sep 11, 2024
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/veterans_matched.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/tests/policy/baseline/gov/states/ks/tax/income/exemptions/ks_exemptions.yaml
Outdated
Show resolved
Hide resolved
...ables/gov/states/ks/tax/income/exemptions/disabled_veteran/ks_disabled_veteran_exemptions.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
PavelMakarchuk
requested changes
Sep 11, 2024
...ov/states/ks/tax/income/exemptions/disabled_veteran/ks_disabled_veteran_exemptions_person.py
Outdated
Show resolved
Hide resolved
...ables/gov/states/ks/tax/income/exemptions/disabled_veteran/ks_disabled_veteran_exemptions.py
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Sep 12, 2024
policyengine_us/variables/gov/states/ks/tax/income/exemptions/ks_exemptions.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
PavelMakarchuk
requested changes
Sep 13, 2024
policyengine_us/variables/gov/states/ks/tax/income/exemptions/ks_exemptions.py
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ks/tax/income/exemptions/ks_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/ks/tax/income/exemptions/ks_exemptions.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/disabled_veteran.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/disabled_veteran.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/disabled_veteran.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5052 +/- ##
=======================================
Coverage 99.12% 99.13%
=======================================
Files 2592 2601 +9
Lines 37707 37805 +98
Branches 162 160 -2
=======================================
+ Hits 37378 37477 +99
+ Misses 297 296 -1
Partials 32 32 ☔ View full report in Codecov by Sentry. |
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
PavelMakarchuk
requested changes
Sep 20, 2024
...ne_us/variables/gov/states/ks/tax/income/exemptions/ks_disabled_veteran_exemptions_person.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/base.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/ks/tax/income/exemptions/amount/disabled_veteran.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
There was a problem hiding this comment.
@MaxGhenis
we have been using veterans_benefits > 0 for the determination of whether the person is a veteran or not, I think adding a bool variable would be appropriate given how we handle other situations like parent etc.
thoughts?
@hua7450 if confirmed
could we add a formula to check if veterans_benefits > 0 and file an issue to consolidate in the rest of the repo
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue4969
PavelMakarchuk
approved these changes
Oct 15, 2024
| @@ -0,0 +1,15 @@ | |||
| description: Kansas provides the following exemption amount for disabled veterans. | |||
There was a problem hiding this comment.
Suggested change
| description: Kansas provides the following exemption amount for disabled veterans. | |
| description: Kansas provides the following exemption amount for each disabled veteran. |
| value_type = bool | ||
| entity = Person | ||
| label = "Eligible person for the Kansas disabled veteran exemption" | ||
| unit = USD |
There was a problem hiding this comment.
Suggested change
| unit = USD |
MaxGhenis
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4969