Zero out SPM broadband subsidy effective 2024-06-01 #5119
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenxin491
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5119 +/- ##
==========================================
+ Coverage 99.01% 99.12% +0.10%
==========================================
Files 2560 2587 +27
Lines 37217 37656 +439
Branches 159 162 +3
==========================================
+ Hits 36851 37327 +476
+ Misses 337 297 -40
- Partials 29 32 +3 ☔ View full report in Codecov by Sentry. |
MaxGhenis
requested changes
Sep 24, 2024
PavelMakarchuk
changed the title
policyengine_us/parameters/gov/simulation/reported_broadband_subsidy.yaml
Show resolved
Hide resolved
policyengine_us/parameters/gov/simulation/reported_broadband_subsidy.yaml
Show resolved
Hide resolved
PavelMakarchuk
requested changes
Oct 5, 2024
| @@ -0,0 +1 @@ | |||
|
|
|||
| @@ -15,12 +15,11 @@ | |||
| output: | |||
| spm_unit_broadband_subsidy: 5 | |||
|
|
|||
| - name: Baseline subsidy test with relevant inputs | |||
| period: 2023 | |||
| - name: Households with reported broadband subsidies have zero starting in 2025 | |||
There was a problem hiding this comment.
could you keep this test as it is and add a new one for 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5003