-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Missouri income tax parameter structure #5255
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5255 +/- ##
==========================================
+ Coverage 99.12% 99.17% +0.04%
==========================================
Files 2592 2605 +13
Lines 37707 37867 +160
Branches 162 161 -1
==========================================
+ Hits 37378 37555 +177
+ Misses 297 278 -19
- Partials 32 34 +2 ☔ View full report in Codecov by Sentry. |
changelog.yaml
Outdated
@@ -8508,3 +8508,8 @@ | |||
added: | |||
- Biden NIIT label and description change. | |||
date: 2024-10-17 19:59:12 | |||
- bump: minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add to changelog_entry.yaml
not to changelog.yaml
- please see other closed PR's for reference
changelog_entry.yaml
Outdated
changes: | ||
changed: | ||
- Remove state codes for Missouri. | ||
date: 2024-10-19 17:56:39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date is auto populated - remove
changelog_entry.yaml
Outdated
changes: | ||
changed: | ||
- Remove state codes for Missouri. | ||
date: 2024-10-19 17:56:39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date: 2024-10-19 17:56:39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename all of these parameter files to remove the mo_
Also please structure them into folders based on program
this will have an effect on the variables - please run the MO tests when adjustments are made and adjust code as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make a folder for joint and name the tow files
owner.yaml
renter.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to income_threshold.yaml
Please make sure that the variable structure is adjusted |
New PR to replace PR #5236