Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Missouri income tax parameter structure #5255

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

leehengpan
Copy link
Collaborator

@leehengpan leehengpan commented Oct 19, 2024

New PR to replace PR #5236

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (cb92a56) to head (63fd928).
Report is 80 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5255      +/-   ##
==========================================
+ Coverage   99.12%   99.17%   +0.04%     
==========================================
  Files        2592     2605      +13     
  Lines       37707    37867     +160     
  Branches      162      161       -1     
==========================================
+ Hits        37378    37555     +177     
+ Misses        297      278      -19     
- Partials       32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leehengpan leehengpan self-assigned this Oct 20, 2024
changelog.yaml Outdated
@@ -8508,3 +8508,8 @@
added:
- Biden NIIT label and description change.
date: 2024-10-17 19:59:12
- bump: minor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to changelog_entry.yaml not to changelog.yaml - please see other closed PR's for reference

changes:
changed:
- Remove state codes for Missouri.
date: 2024-10-19 17:56:39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date is auto populated - remove

changes:
changed:
- Remove state codes for Missouri.
date: 2024-10-19 17:56:39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
date: 2024-10-19 17:56:39

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename all of these parameter files to remove the mo_
Also please structure them into folders based on program

this will have an effect on the variables - please run the MO tests when adjustments are made and adjust code as needed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a folder for joint and name the tow files
owner.yaml
renter.yaml

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to income_threshold.yaml

@PavelMakarchuk PavelMakarchuk marked this pull request as draft October 22, 2024 05:16
@PavelMakarchuk
Copy link
Collaborator

Please make sure that the variable structure is adjusted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants