Add TSWriter #8
Merged
Add TSWriter #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JesseMckinzie
commented
Jun 21, 2024
JesseMckinzie
commented
- Add tensorstore zarr writer
sameeul
reviewed
Jun 25, 2024
src/cpp/utilities/utilities.h
Outdated
| @@ -18,4 +18,10 @@ uint16_t GetDataTypeCode (std::string_view type_name); | |||
| std::string GetUTCString(); | |||
| std::string GetOmeXml(const std::string& file_path); | |||
| std::tuple<std::optional<int>, std::optional<int>, std::optional<int>>ParseMultiscaleMetadata(const std::string& axes_list, int len); | |||
| tensorstore::DataType GetTensorStoreDataType(const std::string& type_str); | |||
| uint16_t GetDataTypeCode (std::string_view type_name); | |||
sameeul
reviewed
Jun 25, 2024
Comment on lines
+21
to
+26
| std::string dtype_str_converted = (dtype_str == "float64") ? "double" : dtype_str; // change float64 numpy type to double | ||
|
|
||
| auto dtype = GetTensorStoreDataType(dtype_str_converted); | ||
|
|
||
| auto dtype_base = ChooseBaseDType(dtype).value().encoded_dtype; | ||
|
|
There was a problem hiding this comment.
I don't think you need this. You can just pass in dtype_str to GetZarrSpecToWrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.