Plugin update: apply-flatfield #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishaq503
requested review from
Nicholas-Schaub,
NHotaling and
hsidky
as code owners
nishaq503
force-pushed
the
updates/apply-flatfield
branch
from
db2fa96
to
4c17fb3
Compare
nishaq503
force-pushed
the
updates/apply-flatfield
branch
2 times, most recently
from
5ac5283
to
0f71097
Compare
nishaq503
force-pushed
the
updates/apply-flatfield
branch
3 times, most recently
from
e041852
to
e14fbe7
Compare
hamshkhawar
requested changes
Dec 15, 2023
| # Output paths | ||
| outDir=/data/outputs | ||
|
|
||
| FILE_EXT=".ome.zarr" |
There was a problem hiding this comment.
Why this FILE_EXT is there?
There was a problem hiding this comment.
This is the env-variable used to have the output images be ome-zarr. It only applies when using the run-plugin script
...mages/apply-flatfield-plugin/src/polus/plugins/transforms/images/apply_flatfield/__init__.py
Outdated
Show resolved
Hide resolved
nishaq503
force-pushed
the
updates/apply-flatfield
branch
3 times, most recently
from
303f343
to
c052ba6
Compare
Fixed! |
nishaq503
force-pushed
the
updates/apply-flatfield
branch
from
0526e98
to
62d73e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated the apply-flatfield plugin to our new standards.
This PR should be merged after theruffPRThis PR should be merged after this PR lands in filepattern2.