Dont require Dockerfile, build before test #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misterbrandonwalker
requested review from
Nicholas-Schaub and
NHotaling
as code owners
misterbrandonwalker
force-pushed
the
patch_actions_workflow
branch
from
126ee5e
to
4a4d006
Compare
nishaq503
requested changes
Mar 29, 2024
There was a problem hiding this comment.
The changes to the docker build logic and the conda tests look good to me. The only change needed is that of the workflow_call line. That said, I still need to see an example of this workflow running successfully for each of the conditional paths. If you have questions on how to make this happen, please contact me over Slack.
misterbrandonwalker
force-pushed
the
patch_actions_workflow
branch
from
4a4d006
to
a05fcfb
Compare
Nicholas-Schaub
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of the updated workflow: