Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omero-download-tool #535

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

hamshkhawar
Copy link
Member

This PR allows to retrieve datasets from omero ncats server

@hamshkhawar hamshkhawar requested a review from hsidky as a code owner May 17, 2024 00:03
| --------------- | ------------------------------------------------------------ | ------ | ----------- |
| `--dataType` | Object types to be retreived from Omero Server | Input | String |
| `--name ` | Name of an object | Input | String |
| `--id ` | Identification of an object of an object | Input | Integer |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `--id ` | Identification of an object of an object | Input | Integer |
| `--objectId ` | Identification of an object of an object | Input | Integer |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


## Sample docker command:
```bash
docker run -e OMERO_USERNAME=$OMERO_USERNAME -e OMERO_PASSWORD=$OMERO_PASSWORD -v /home/ec2-user/data/:/home/ec2-user/data/ polusai/omero-download-tool:0.1.0-dev0 --dataType="plate" --id=108 --outDir=/home/ec2-user/data/output```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker run -e OMERO_USERNAME=$OMERO_USERNAME -e OMERO_PASSWORD=$OMERO_PASSWORD -v /home/ec2-user/data/:/home/ec2-user/data/ polusai/omero-download-tool:0.1.0-dev0 --dataType="plate" --id=108 --outDir=/home/ec2-user/data/output```
docker run -e OMERO_USERNAME=$OMERO_USERNAME -e OMERO_PASSWORD=$OMERO_PASSWORD -v /home/ec2-user/data/:/home/ec2-user/data/ polusai/omero-download-tool:0.1.0-dev0 --dataType="plate" --objectId=108 --outDir=/home/ec2-user/data/output```

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bengtl I have removed example folder and modify preview function

Copy link
Member

@bengtl bengtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismatch in parameter 'objectId' <-> 'id'

@hamshkhawar
Copy link
Member Author

Mismatch in parameter 'objectId' <-> 'id'

Mismatch in parameter 'objectId' <-> 'id'

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants