Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Make link for new github repo open in new tab #828

Closed
wants to merge 1 commit into from

Conversation

yufengg
Copy link

@yufengg yufengg commented Dec 13, 2014

Unfortunately GitHub markdown does not support opening links in a new tab. This change replaces the link to create a new github repo with some html that does that.

Here's a github issue thread that shows that markdown is not likely to support this natively in the future: mojombo/github-flavored-markdown#28

Unfortunately GitHub markdown does not support opening links in a new tab. This change replaces the link to create a new github repo with some html that does that.
@ebidel
Copy link
Contributor

ebidel commented Dec 13, 2014

We don't use github markdown. Clicking that link on https://www.polymer-project.org/docs/start/reusableelements.html works exactly as I'd expect.

@yufengg
Copy link
Author

yufengg commented Dec 13, 2014

The trouble is that it opens it in the same window, and thus wipes out the
progress made on the page. One can make an argument for opening it in a new
tab being a better experience.

@ebidel
Copy link
Contributor

ebidel commented Dec 14, 2014

I'm fairly certain all external links on the site open in the same tab. That's typically what users expect. If they want a new tab, they can use the ctrl/cmd key.

@yufengg
Copy link
Author

yufengg commented Dec 15, 2014

Fair enough. Just thought it was odd compared to other websites' linking
standards. At least now I know what to expect too :)

@addyosmani
Copy link
Member

Reviewing, this appears to work as expected and we don't intend on changing the current behaviour. Closing. If there's still interest in us doing this feel free to reopen.

@addyosmani addyosmani closed this Jan 9, 2015
@Gribbs
Copy link

Gribbs commented Sep 7, 2015

Opening link in a new tab should be an option. It's useability 101. Users should not have to lose their current page if the page designer doesn't want it to work like that (like me right now).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants