-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: regression by reverting fix that returned 206 when first-pos=length in Range header #3006
Conversation
4fe358d
to
83272d9
Compare
@laurenceisla Just so I understand. Once we merge this, the next step would be to do #3007 to fix #2824 ? |
How about adding a test-case with offset=0 and empty response together with the revert, so that #2824 (comment) can never break again? |
And probably a test-case for this as well:
|
@steve-chavez Not necessarily, but I think it would be ideal and more straightforward to do it that way (note that it's a breaking change).
@wolfgangwalther Good idea, I'll add those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like ra-data-postgrest
uses the Prefer: count=exact
header by default.
That's why the test I added for only offset=0
did not break for v11.2.1, but I'll leave it just in case.
…n = length in a Range header
3c0b9b9
to
9b1ce54
Compare
Related to: #2824 (comment)