Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow not_null value for the is operator #3818

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

taimoorzaeem
Copy link
Collaborator

Fixes #3747.

CHANGELOG.md Outdated
@@ -13,6 +13,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- #3560, Log resolved host in "Listening on ..." messages - @develop7
- #3727, Log maximum pool size - @steve-chavez
- #1536, Add string comparison feature for jwt-role-claim-key - @taimoorzaeem
- #3747, Add `not_null` filter value to pgrst query - @taimoorzaeem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- #3747, Add `not_null` filter value to pgrst query - @taimoorzaeem
- #3747, Allow `not_null` value for the `is` operator - @taimoorzaeem

Comment on lines 1045 to 1048
.. note::

PostgREST also provides ``is.not_null`` filter which works the same as ``not.is.null``. See `#3747 <https://github.com/PostgREST/postgrest/issues/3747>`_.

Copy link
Member

@steve-chavez steve-chavez Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only document this on

is :code:`IS` checking for exact equality (null,true,false,unknown)

Then delete this note (it's easy to miss, and it's not that relevant on the embedding docs).

Suggested change
.. note::
PostgREST also provides ``is.not_null`` filter which works the same as ``not.is.null``. See `#3747 <https://github.com/PostgREST/postgrest/issues/3747>`_.

@taimoorzaeem taimoorzaeem changed the title feat: add not_null filter to pgrst query feat: allow not_null value for the is operator Dec 19, 2024
@steve-chavez steve-chavez merged commit a9d74eb into PostgREST:main Dec 19, 2024
25 checks passed
@taimoorzaeem taimoorzaeem deleted the not-null/issue3747 branch December 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Does postgrest not support "not null" as valud is value?
2 participants