Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change feature value table to add position field #925

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Change feature value table to add position field #925

wants to merge 1 commit into from
+4 −0

Conversation

ks129
Copy link

@ks129 ks129 commented Sep 27, 2024

Questions Answers
Description? Added position field to feature value table in 9.0.0. Part of PrestaShop/PrestaShop#37042
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? part of PrestaShop/PrestaShop#35499 and PrestaShop/PrestaShop#32267
Sponsor company -
How to test? After upgrading to 9.0.0, feature value table should have position field.

@ps-jarvis
Copy link
Collaborator

Hello @ks129!

This is your first pull request on autoupgrade repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ks129 ks129 mentioned this pull request Sep 27, 2024
Open
@ga-devfront ga-devfront added the Blocked Status: The issue is blocked by another task label Sep 30, 2024
@ga-devfront
Copy link
Contributor

Thank you for your contribution! I have blocked the PR while the PR relating to it is merged on the Core. Do not hesitate to ping me if it is merged and I have not reacted in the meantime.

Quetzacoalt91
Quetzacoalt91 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you. Labeling as "Blocked" until the PR is merged on PrestaShop repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees
No one assigned
Labels
Blocked Status: The issue is blocked by another task Waiting for rebase
Projects
PR Dashboard
Status: Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ks129 @ps-jarvis @ga-devfront @Quetzacoalt91