Separation of the backup process and the update process #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M0rgan01
force-pushed
the
extract-backup-tasks
branch
23 times, most recently
from
6127d77
to
49a52cc
Compare
M0rgan01
force-pushed
the
extract-backup-tasks
branch
5 times, most recently
from
8e358d2
to
5ffadd0
Compare
M0rgan01
force-pushed
the
extract-backup-tasks
branch
from
fd46aba
to
9806817
Compare
Quetzacoalt91
previously approved these changes
Oct 11, 2024
M0rgan01
force-pushed
the
extract-backup-tasks
branch
from
9806817
to
1736bbc
Compare
Quetzacoalt91
previously approved these changes
Oct 11, 2024
M0rgan01
force-pushed
the
extract-backup-tasks
branch
from
1736bbc
to
9b55299
Compare
M0rgan01
force-pushed
the
extract-backup-tasks
branch
2 times, most recently
from
28dc4e3
to
03af9b4
Compare
M0rgan01
force-pushed
the
extract-backup-tasks
branch
from
03af9b4
to
485a433
Compare
|
Quetzacoalt91
approved these changes
Oct 17, 2024
AureRita
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as you can see :
Tested from (with UI) : ✔️
1.7.8.9 to 8.1.7
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0
The only things seen is the modal that are displayed even if the upgrade is ended, seen with you, it's ok
recording.300.webm
Tested from (with CLI) :
1.7.8.9 to 8.2
8.0.4 to 8.2
8.2 to 9.0.0 ❌
8.0.4 to 9.0.0 ❌ (it seems to be an issue already in our scope, seen with you)
Because the PR seems to works, It's QA ✔️
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BC breaks
The upgrade process no longer allows for a backup. It now has its own process and command.