Improve UpdateConfig and ConfigurationValidator #947
Merged
+208
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Oct 9, 2024
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Refactoring of the UpdateConfig task, adding cases in the ConfigurationValidator. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | - |
| Sponsor company | - |
| How to test? | Taking the configuration into account works as before, on the CLI and on the WEB version |
M0rgan01
changed the title
nicosomb
previously approved these changes
Oct 10, 2024
M0rgan01
force-pushed
the
improve-config-validator
branch
3 times, most recently
from
652599b
to
c42aea8
Compare
nicosomb
previously approved these changes
Oct 10, 2024
M0rgan01
force-pushed
the
improve-config-validator
branch
from
c42aea8
to
80a6f42
Compare
ga-devfront
previously approved these changes
Oct 14, 2024
M0rgan01
force-pushed
the
improve-config-validator
branch
from
80a6f42
to
5336093
Compare
Quetzacoalt91
previously approved these changes
Oct 15, 2024
|
Even though this PR is fixing an issue, there is still an error happening while reaching the configuration page.
|
M0rgan01
force-pushed
the
improve-config-validator
branch
from
5336093
to
6bf1a86
Compare
|
Quetzacoalt91
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.