Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Review Microdata to product #158

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

rodriciru
Copy link

Currently, there's no schema markup for review.
Google complains about it, so this PR fixed that.

imagen

@Hlavtox
Copy link
Contributor

Hlavtox commented Mar 29, 2023

I think we removed it some time ago. The review data should be put in the header, is not the case?

@rodriciru
Copy link
Author

In that case I'm ok, but for me there's no review in any part of the page...

@rodriciru
Copy link
Author

Sorry.
There's an AggregateRating (not in my theme), but not the reviews (in classic and hummingbird)

@rodriciru
Copy link
Author

I made a PR long time ago to expose reviews to use in header. This involves the modification of the template, but it is still open...
Maybe its outdated now...
#140

@kpodemski
Copy link
Contributor

Hi @rodriciru

I think it is not needed anymore, as we should have reviews info in JSON-LD :)

@rodriciru
Copy link
Author

Great. But as for the moment, there's no such info (not even in the JSON_LD) this fix that for all templates that use this module.
Or we can look at other PR that adds this info to be used in the JSON-LD #140

@matks
Copy link
Contributor

matks commented Apr 12, 2023

@Hlavtox @kpodemski @rodriciru How can we move forward? Looks like discussion is stuck on a disagreement

@Hlavtox
Copy link
Contributor

Hlavtox commented Apr 12, 2023

I will summarize.

@rodriciru
Copy link
Author

I will summarize.

* In https://github.com/PrestaShop/classic-theme/blob/develop/templates/_partials/microdata/product-jsonld.tpl, there is a rating microdata provided in a limited form.

* I agree that adding more structured data is always good.

* We removed all inline microdata in previous versions of Prestashop, it's not good to clutter the code with them. They should be in the header.

* So, can we use `displayHeader` for this purpose @rodriciru?

I'm not a PrestaShop dev, so my understanding of PrestaShop is limited. Anyway, I do my best

Anyway, if has such info in microdata is a problem, we can close this PR and look to this PR #140 which populates comments, and reviews, so every template can make use of it in the way the want

@LouisAUTHIE LouisAUTHIE closed this Aug 4, 2023
@LouisAUTHIE LouisAUTHIE reopened this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants