Prevent MakeRatingMandatory feature breaks review in 3rd party theme #210
Conversation
| @@ -40,6 +40,8 @@ jQuery(document).ready(function () { | |||
| const commentPostErrorModal = $('#product-comment-post-error'); | |||
|
|
|||
| const criterionsList = $('#criterions_list'); | |||
| if (typeof productCommentMandatoryMessage === 'undefined') | |||
| productCommentMandatoryMessage = 'Please choose a rating for your review.'; | |||
There was a problem hiding this comment.
It has to be a translatable phrase.
There was a problem hiding this comment.
Certainly it is, in this template file. This PR is a patch for hummingbird 0.2.0 or third-party themes that has their own override post-comment-modal.tpl - not implemented productcomment 7.0.0's new review-mandatory feature yet. In these cases, a non-technical shop-owner will just complain ''my client can not do review after upgrading productcomment to v7.0.0'' , then an English phrase is clearly better than a broken review.
|
Please put this code to hook after line 7 on product-comments-list.tpl
and please don't change file post-comment.js |
|
@pawelkierklo hummingbird theme has its own override product-comments-list.tpl, so putting productCommentMandatoryMessage declaration in module template file won't solve the problem. |
The issue was locally solved in hummingbird beta but still happens in hummingbird 0.2.0.
This PR solve the issue globally for all themes. If the shop owner want to use their own translation string then they must take care escape characters themselves ;)
Before PR you will see the issue as described in the above ticket, after PR the issue won't happen.