-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.17.1 support #650
base: master
Are you sure you want to change the base?
1.17.1 support #650
Conversation
Looks like tests are passing. Do things seem to work? |
} | ||
}, // FIXME: fake heightmap | ||
chunkData: chunk.dump(), | ||
blockEntities: [] | ||
}) | ||
if (registry.supportFeature('lightSentSeparately')) { | ||
if (registry.supportFeature('dimensionDataIsAvailable')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the feature seems unrelated with the content of this if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied directly from mineflayer code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/PrismarineJS/mineflayer/blob/5c71edf48bb2f2dfa16cddb9af5baa0c4d55cf0d/lib/plugins/blocks.js#L264 definitely has the same issue
THINGS DO NOT WORK. Particularly, world saving is completely borked and sometimes the server crashes when trying to send chunk packets (all to do with the palette set to null error). |
I made PrismarineJS/prismarine-provider-anvil#74 which I think should fix this anvil problem Can you check if that helps the error you were seeing @Pandapip1 ? |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/[email protected] |
I'm still getting the following error, even after updating:
|
ok that's a different error than the palette |
would be great to have a test showing this, would make it faster to debug |
PrismarineJS/prismarine-provider-anvil#75 / PrismarineJS/prismarine-provider-anvil#73 is the blocker here |
hey getting now this error March 29th 2024, 18:47:08 [ERROR]: Error: TypeError: this.skyLightMask.toLongArray is not a function after world safe in 1.17.1 but yeah im tryng to fix it at moment i just dont know if its has somthing to do whit the anvil or just whit the chunkColumn.js |
i also try fixing redstone like piston activated and all stuff |
i fixed this error |
just need to fix the lightnigs |
ok made now the 1.17.1 support |
oh no relised world dosnt safe you just can join and build but nothing gets saved |
@rom1504 in which file is the savin logik? |
Blocked by
PrismarineJS/diamond-square#15, PrismarineJS/prismarine-provider-anvil#73.