-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOUR-11873: Detach Object - Create a method o helper function, that disconect the object with the source and target flow #1761
base: next
Are you sure you want to change the base?
Conversation
…isconect the object with the source and target flow
…if clearSelection param is false
Passing run #1001 ↗︎
Details:
Review all test suite changes for PR #1761 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next warnings must be reviewed:
- Unexpected mutation of "owner" prop
- Unexpected mutation of "planeElements" prop
- Unexpected mutation of "node" prop
- Unexpected mutation of "rootElements" prop
Or provide a sufficiently valid reason for this issue to be overlooked. But by definition, properties that are passed to a child component as "props" should not be modified directly.
outgoingLink.component.shapeView.targetAnchor.toJSON(), | ||
]; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check missing space
const outgoingLink = this.modeler.getElementByNodeId(outgoing.id); | ||
return [ | ||
incomingLink.component.shapeView.sourceAnchor.toJSON(), | ||
outgoingLink.component.shapeView.targetAnchor.toJSON(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validate if variables (incomingLink, outgoingLink) is not null before return.
SonarQube Quality Gate |
Issue & Reproduction Steps
Expected behavior:
As a developer,
I want to have a helper function .
so I can detach the object from flow automatically
Actual behavior:
n/a
Solution
detach_object_from_flow.webm
How to Test
Test the steps above
Related Tickets & Packages
Code Review Checklist