FOUR-11873: Detach Object - Create a method o helper function, that disconect the object with the source and target flow #1761

rodriquelca · 2023-12-07T21:19:50Z

Issue & Reproduction Steps

Expected behavior:
As a developer,
I want to have a helper function .
so I can detach the object from flow automatically
Actual behavior:
n/a

Solution

DetachObjectFlows class was added
During the shap drag, a validation was added to detach

detach_object_from_flow.webm

How to Test

Test the steps above

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-11873

Code Review Checklist

I have pulled this code locally and tested it on my instance, along with any associated packages.
This code adheres to ProcessMaker Coding Guidelines.
This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
This solution fixes the bug reported in the original ticket.
This solution does not alter the expected output of a component in a way that would break existing Processes.
This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
This ticket conforms to the PRD associated with this part of ProcessMaker.

…isconect the object with the source and target flow

…if clearSelection param is false

cypress · 2023-12-07T21:32:07Z

Passing run #1001 ↗︎

0	276	83	0	0

Details:

Merge `822b166` into `7023c18`...
Project: modeler	Commit: `fcb023b7eb ℹ️`
Status: Passed	Duration: 10:50 💡
Started: Dec 13, 2023 6:08 PM	Ended: Dec 13, 2023 6:19 PM

Review all test suite changes for PR #1761 ↗︎

gproly

Next warnings must be reviewed:

Unexpected mutation of "owner" prop
Unexpected mutation of "planeElements" prop
Unexpected mutation of "node" prop
Unexpected mutation of "rootElements" prop
Or provide a sufficiently valid reason for this issue to be overlooked. But by definition, properties that are passed to a child component as "props" should not be modified directly.

gproly · 2023-12-12T21:06:11Z

src/components/modeler/DetachObjectFlows.js

+      outgoingLink.component.shapeView.targetAnchor.toJSON(),
+    ];
+  }
+}


check missing space

gproly · 2023-12-12T21:10:00Z

src/components/modeler/DetachObjectFlows.js

+    const outgoingLink = this.modeler.getElementByNodeId(outgoing.id);
+    return [
+      incomingLink.component.shapeView.sourceAnchor.toJSON(),
+      outgoingLink.component.shapeView.targetAnchor.toJSON(),
