Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19781 Improve load in cypress tests #1889

Open
wants to merge 5 commits into
base: release-2024-fall
Choose a base branch
from

Conversation

caleeli
Copy link
Collaborator

@caleeli caleeli commented Oct 28, 2024

Issue & Reproduction Steps

  • Javascript sizes are very large
  • Browser sometimes do not wait for modeler to be loaded before run the tests

Solution

  • Reduce the javascript sizes
  • Add a better wait for modeler to be loaded

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 28, 2024

modeler    Run #1554

Run Properties:  status check passed Passed #1554  •  git commit dda19598df: FOUR-19781 Improve load in cypress tests
Project modeler
Branch Review FOUR-19781
Run status status check passed Passed #1554
Run duration 05m 38s
Commit git commit dda19598df: FOUR-19781 Improve load in cypress tests
Committer David Callizaya
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 83
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 277
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants