Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19828 | Fields and Layout Icons Not Displaying in Screen Template Cards #7636

Open
wants to merge 4 commits into
base: release-2024-fall
Choose a base branch
from

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Oct 25, 2024

Issue

Ticket: FOUR-19828

In the Screen Templates Panel in screen-builder, when selecting a Template, the icons for applying 'Fields' and 'Layout' are not displaying within the Screen Template Card.

Solution

  • Update svg files for 'fields-icon' and 'layout-icon' use currentColor as the stroke and fill colors.
  • Rerun npm run dev-font to recreate the icons

How to Test

  1. Go to branch observation/FOUR-19828 in processmaker.
  2. Go to Designer → Screens. Open a Screen to edit.
  3. Select 'Templates' from the top menu bar. Select a template card.
  4. When the template card opens:
    • The icons for all of the template options should appear.

ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!
Screenshot 2024-10-25 at 4 15 38 PM

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-eca4823f2e.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-eca4823f2e.engk8s.processmaker.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants