Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support highway="trunk" for foot and bicycle in some countries #6703

Closed
wants to merge 0 commits into from

Conversation

tombay
Copy link

@tombay tombay commented Sep 21, 2023

Issue

What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.

An issue #6710 has been logged (reopening #6701).
Address the issue of highway=trunk (and trunk_link) being blocked for foot and bicycle profiles. Discussed in https://wiki.openstreetmap.org/wiki/Key:motorroad and https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access_restrictions (esp #Alternative_ideas) proposed to address issue via
osrm-backend ... --location-dependent-data trunk-allowed.geojson.
The 30 countries allowing trunk access are include in the polyline data.

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@tombay tombay marked this pull request as draft September 21, 2023 11:52
@tombay tombay marked this pull request as ready for review September 21, 2023 12:10
data/trunk_allowed.geojson Outdated Show resolved Hide resolved
profiles/bicycle.lua Outdated Show resolved Hide resolved
profiles/foot.lua Outdated Show resolved Hide resolved
profiles/lib/local_trunks.lua Outdated Show resolved Hide resolved
profiles/lib/way_handlers.lua Outdated Show resolved Hide resolved
@tombay tombay marked this pull request as draft October 3, 2023 05:47
@tombay tombay marked this pull request as ready for review October 3, 2023 05:51
@tombay tombay marked this pull request as draft October 4, 2023 22:00
@tombay tombay marked this pull request as ready for review October 8, 2023 02:59
@tombay tombay changed the title Tombay trunk allowed - Tombay trunk allowed - support highway="trunk" for foot and bicycle in some countries Oct 13, 2023
@tombay tombay changed the title Tombay trunk allowed - support highway="trunk" for foot and bicycle in some countries support highway="trunk" for foot and bicycle in some countries Oct 13, 2023
docs/profiles.md Outdated
@@ -83,6 +83,8 @@ access.lua | Function for finding relevant access tags
destination.lua | Function for finding relevant destination tags
maxspeed.lua | Function for determining maximum speed
guidance.lua | Function for processing guidance attributes
local_trunks.lua |Function to check trunk roads for access based on country
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local_trunks.lua |Function to check trunk roads for access based on country
local_trunks.lua | Function to check trunk roads for access based on country

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopen, not resolved.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi frodrigo.
I assume the issue is PR #6708 (which resolves PR #6697). I commented on #6697 on 4 Oct while I was working on my issue. I included my changes in my resolution. The issue #6703 (or #6710) addresses the issue where bicycle (and foot) access is allowed on highway="trunk" in some countries.
If #6708 is added the set of countries is reduced. (docs/profiles.md line 400 in this PR).
If #6708 is to be added to Project-OSRM:master I will move this back to draft and then reopen when it is added.
Ciao
Tom

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@systemed What do you think of this change request and two PR ?

docs/profiles.md Outdated
```
'BEL', 'CHL', 'DEU', 'FIN', 'FRA', 'GRC', 'GBR', 'HRV', 'NLD', 'RUS'.
```
[if the changes in bicycle.lua are are included this comment can be removed]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[if the changes in bicycle.lua are are included this comment can be removed]
[if the changes in bicycle.lua are included this comment can be removed]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopen, not resolved.

@tombay tombay requested a review from frodrigo December 10, 2023 01:02
@frodrigo
Copy link
Member

frodrigo commented Feb 8, 2024

It looks like to me the PR now content unrelated changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants