Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/misc DSD refactoring #17

Merged
merged 2 commits into from
Jan 6, 2024
Merged

enhancement/misc DSD refactoring #17

merged 2 commits into from
Jan 6, 2024

Conversation

thescientist13
Copy link
Member

  1. Per leverage getRootNode() for referencing Shadow DOM based parent node reference in JSX output wcc#109, updating the event handling in the Card component as we can alternatively just use getRootNode
  2. Per browser warning about "declarative Shadow DOM has not been enabled by includeShadowRoots" wcc#130, this resolves the warnings being seen in Chrome around injecting DSD from backend APIs.

@thescientist13 thescientist13 added the enhancement New feature or request label Jan 4, 2024
This was referenced Jan 4, 2024
Merged
Merged
@thescientist13 thescientist13 changed the title enhancement/misc dsd refactorings enhancement/misc DSD refactorings Jan 4, 2024
@thescientist13 thescientist13 changed the title enhancement/misc DSD refactorings enhancement/misc DSD refactoring Jan 4, 2024
@thescientist13 thescientist13 merged commit 615d223 into main Jan 6, 2024
4 checks passed
@thescientist13 thescientist13 deleted the enhancement/misc-dsd-refactorings branch January 6, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13