Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/issue 1137 have adapted SSR pages return text/html content type #1138

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Aug 7, 2023

Related Issue

resolves #1137

Summary of Changes

  1. Make sure SSR pages return a text/html content type

TODO

  1. Add test cases

@thescientist13 thescientist13 added bug Something isn't working CLI SSR labels Aug 7, 2023
@thescientist13 thescientist13 changed the title have SSR pages return text/html content type have SSR pages return text/html content type Aug 7, 2023
@thescientist13 thescientist13 changed the title have SSR pages return text/html content type have serverless SSR pages return text/html content type Aug 7, 2023
@thescientist13 thescientist13 changed the title have serverless SSR pages return text/html content type bug/issue 1137 have serverless SSR pages return text/html content type Aug 7, 2023
@thescientist13 thescientist13 changed the title bug/issue 1137 have serverless SSR pages return text/html content type bug/issue 1137 have adapted SSR pages return text/html content type Aug 7, 2023
@thescientist13 thescientist13 merged commit 71a2f2a into release/0.29.0 Aug 10, 2023
8 checks passed
@thescientist13 thescientist13 deleted the bug/issue-1137-ssr-pages-have-incorrect-content-type branch August 10, 2023 12:42
@thescientist13 thescientist13 mentioned this pull request Aug 10, 2023
25 tasks
thescientist13 added a commit that referenced this pull request Aug 12, 2023
…#1138)

* have SSR pages return text/html content type

* add header test cases for adapter SSR pages
thescientist13 added a commit that referenced this pull request Nov 9, 2023
…#1138)

* have SSR pages return text/html content type

* add header test cases for adapter SSR pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI SSR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter SSR pages are rendering with incorrect content type header
1 participant