Docs/issue 1004 document latest status for non standard import formats #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
commented
Oct 16, 2023
| @@ -217,7 +217,7 @@ console.log(json); // { status: 200, message: 'some data' } | |||
| ``` | |||
|
|
|||
| **Steps** | |||
| 1. Make sure you are using Node `v18.12.1` | |||
| 1. Make sure you are using Node `v18.15.0` | |||
There was a problem hiding this comment.
Actually, 18.12.1 I think still works? So maybe this doesn't need to specifically called out 🤷
…ard-import-formats
thescientist13
deleted the
docs/issue-1004-document-non-standard-import-formats
branch
thescientist13
added a commit
that referenced
this pull request
Nov 9, 2023
#1166) * update documentation around custom imports * update test case descriptions and add placeholder prerender typescript test case * update test case descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
"resolves" #1004
It seems coming out of #952 , using
importeven with .gql files seems to be working just fine, and since this also works with JSX as evidenced in our test cases, I think this means everything is now compatible!Summary of Changes
Not sure what the specific fix was, but possibly as part #1151 ?