Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 1253 init baseline starting point #1254

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jun 26, 2024

Related Issue

resolves #1253

Summary of Changes

  1. Refresh the init template landing page with simple custom element example and better link documentation
Screenshot 2024-08-02 at 9 46 44 PM Screenshot 2024-08-02 at 9 45 48 PM Screenshot 2024-08-02 at 9 46 20 PM

To test, run

$ cd packages/init/src/template
$ npx @greenwood/cli@alpha develop

TODO

  1. continue tweaking animation by centering the leaf / refactoring class names
  2. Handle FOUC on the logo
  3. odd styling issue at tablet breakpoint
  4. validate / update test cases
  5. Handle loading Geist font (do we need / want it, just use system font?) - system font is fine
  6. Add website links (this might come before the new website, so may have to create a tracking item for all links that need to get changed)
  7. get final logo - update Greenwood logo with official logo from original source assets www.greenwoodjs.dev#47
  8. validate build / serve tasks
  9. 🚨 need to "downgrade" our usage of import attributes per polyfill configurations for import maps and attributes #1268

Tracking Items

  1. remove default Greenwood layouts content - remove default content (pages / layouts) from Greenwood  #1271
  2. New Prompts for TS / markdown support - init scaffolding should prompt for installing common plugins (TypeScript and markdown) #1270
  3. pnpm support - expand package manager options for init scaffolding #1272

Questions

  1. should greenwood even have default layouts? - Per our meeting, probably not?

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) question Further information is requested documentation Greenwood specific docs Init labels Jun 26, 2024
@thescientist13 thescientist13 self-assigned this Jun 26, 2024
@thescientist13 thescientist13 linked an issue Jun 27, 2024 that may be closed by this pull request
2 tasks
@thescientist13 thescientist13 force-pushed the enhancement/issue-1253-init-baseline-starting-point branch from 389bee6 to 2305be2 Compare August 3, 2024 02:01
@thescientist13 thescientist13 marked this pull request as ready for review August 3, 2024 02:18
@thescientist13 thescientist13 force-pushed the enhancement/issue-1253-init-baseline-starting-point branch from 2305be2 to c5ad90b Compare August 29, 2024 01:39
@thescientist13 thescientist13 removed the question Further information is requested label Aug 29, 2024
@thescientist13 thescientist13 merged commit 9f31034 into release/0.30.0 Aug 29, 2024
8 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-1253-init-baseline-starting-point branch August 29, 2024 02:16
thescientist13 added a commit that referenced this pull request Nov 2, 2024
* WIP landing page with spinning logo

* flesh out cards conent

* comment out fonts

* use SVG logo

* restore (broken) fonts

* windy leaf animation

* fix leaf logo

* add links

* responsive and misc styling tweaks

* correctly align logo

* update test case for basic content checks

* ESLint ignore init template contents

* downgrade usage of import attributes

* fix typo

* add xmlns to SVG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) Init
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve init package scaffolding baseline starting point
1 participant