Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 124 refactor handling and logging for entry points and dependencies with no custom element export #125

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 2, 2023

Related Issue

resolves #124

Summary of Changes

  1. Don't log out when checking for custom elements in initializeCustomElement
  2. Add logging if renderToString entry point is not a custom element
  3. Updated no export spec

@thescientist13 thescientist13 added documentation Improvements or additions to documentation enhancement Improvement to existing functionality labels Dec 2, 2023
@thescientist13 thescientist13 self-assigned this Dec 2, 2023
@thescientist13 thescientist13 changed the title enhancement/issue 124 refactor handling and logging for entry points and dependencies with … enhancement/issue 124 refactor handling and logging for entry points and dependencies with no custom element export Dec 2, 2023
@thescientist13 thescientist13 merged commit b29d981 into master Dec 21, 2023
12 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-124-no-custom-element-export-error-handling branch December 21, 2023 13:20
`
: serialize(finalTree);
} else {
console.warn('WARNING: No custom element class found for this entry point.');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In retrospect, maybe this should be more of a debug instead of warn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gracefully and accurately handle "empty" entry points and dependency files that don't export a custom element
1 participant