Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue 96 enhanced copy to clipboard #120

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 26, 2024

Related Issue

resolves #96

Summary of Changes

  1. Created a CtC Block component with support for two variants
    • runners - For npm, yarn, and pnpm based code samples
    • snippet - For any other sort of code sample, e.g. HTML, CSS, JS, etc
  2. Added some docs regarding considerations around using WCs + markdown (since we had to tweak one of the examples)

TODO

  1. getting a Stylelint error in GitHub, but not locally? 🤔 - rebase fixed it
  2. this snippet formatting is looking borked on production builds both on the page and the copy paste output?
  3. logos are missing on mobile
  4. get internal feedback
  5. add Storybook examples
  6. add test cases
  7. technically the $ should be white in the output for runners variant
  8. naming / align with home page button icon
  9. needs upstream patches PR - chore/upgrade greenwood v0.30.0 alpha.7 #107
  10. apply to all docs / guides content - wait for Docs Page #31
  11. try and hide initial content
  12. (nice to have) figure out snippet formatting bug

Thoughts / Questions

  1. Not sure if we will need a generic shell commands option?
  2. Could we use <details> + <summary>, or maybe popover for this? Perhaps align with Progressively Enhanced Capabilities content #81 ?

@thescientist13 thescientist13 added docs Greenwood specific content like docs and guides enhancement New feature or request question Further information is requested labels Oct 26, 2024
@thescientist13 thescientist13 self-assigned this Oct 26, 2024
Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit fffe84b
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/67255bf1f3f9b00008e2470d
😎 Deploy Preview https://deploy-preview-120--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 changed the title feature/issue 96 copy clipboard feature/issue 96 copy to clipboard Oct 31, 2024
@thescientist13 thescientist13 changed the title feature/issue 96 copy to clipboard feature/issue 96 enhanced copy to clipboard Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Greenwood specific content like docs and guides enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Copy to Clipboard" feature for code snippets on docs / guides pages
1 participant